Continuous integration builds have changed state:
Travis build 3833. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/419064487.
Appveyor build 3632. State: success. Details:
*with a debug build, sorry.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport.
That bug is really fun but the streamreader isn't to blame. ;-)
The problem is that the float_32() call not only returns the value but also
modifies the internal state of the stream. As a consequence, the order of
assignment to x and y matters (or more precisely, the order in which the
Continuous integration builds have changed state:
Travis build 3831. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/419041575.
Appveyor build 3630. State: success. Details:
The proposal to merge lp:~widelands-dev/widelands/multiplayer-ui into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/multiplayer-ui/+merge/353523
--
Your team Widelands Developers is subscribed to
The proposal to merge
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
--
Your team
> That code should be semantically identical?
That's what I thought too when I broke it. I really don't want to dig into the
streamreader right now though - there is some subtle unexpected side-effect
going on there.
@bunnybot merge
--
Review: Disapprove
--
https://code.launchpad.net/~widelands-dev/widelands/skipped_statistics/+merge/353552
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/skipped_statistics into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/skipped_statistics/+merge/353552
--
Your team Widelands Developers is
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1774591-loading-screen-tips into lp:widelands.
Commit message:
Fix horizontal centering for game tips.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1774591 in widelands: "Center game/editor tips"
The proposal to merge lp:~widelands-dev/widelands/multiplayer-ui into
lp:widelands has been updated.
Commit message changed to:
Multiplayer-ui tweaks: less empty spaces and more space for important content.
- chat has more space
- map_info scales better
- client_info has no height restriction
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/multiplayer-ui/+merge/353523
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/multiplayer-ui.
___
Mailing list:
Now I am confused. That code should be semantically identical?
As peformance optimizer I see the the extra null-assignement is a waste :-)
Can you add a comment what compiler/enviroment causes this problem?
I tested this in bzr8791[trunk] and it was ok for me.
--
Toni Förster has proposed merging
lp:~widelands-dev/widelands/skipped_statistics into lp:widelands with
lp:~widelands-dev/widelands/bug-1786613-10s-return-skipped as a prerequisite.
Commit message:
skipping a work program decreases productivity accordingly
Requested reviews:
Widelands
The proposal to merge lp:~widelands-dev/widelands/fix_osx_nightlies into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_osx_nightlies/+merge/353456
--
Your team Widelands Developers is subscribed
15 matches
Mail list logo
