Looks good to me, let's have it!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-better-syncstreams/+merge/361922
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-better-syncstreams.
I got 2 leak entries previously, going through the same line in persistence.cc.
Now I'm only getting 1.
Ma C is not good enough for me to touch Eris, but if you can fix it, we could
contribute our fix to the eris project as well.
--
Continuous integration builds have changed state:
Travis build 4461. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/491840111.
Appveyor build 4249. State: success. Details:
Ok I tested it and it is a completely logical behaviour:
1. the assert tests the size of a field object to ensure the preprocessor
command to pack this struct was successful
2. before my changes this object had 10 bytes + 2 times the standard address
width (sizeof (void*))
3. I added a property
The proposal to merge lp:~widelands-dev/widelands/coroutine-error-collectors
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/coroutine-error-collectors/+merge/362956
--
Your team Widelands
the check for WIN32 is an ifndef check so in fact the check for Windows is less
strict.
My code adds a new property to the field struct so I believe it is increased in
size and therefore the check for all other Systems than Windows fail due to the
more restrictive size check.
As these
Review: Approve
Tested and working :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/coroutine-error-collectors/+merge/362956
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/coroutine-error-collectors.
The check under Windows is more strict, so unifying the check will not make the
assert error go away. The roper fix is to understand what the problem is - I
expect that there is a reason that somebody put that assert there and that
there is a bug in the new code.
--
The check that is failing is checking whether a field instance is tightly
packed. (whatever that means)
However the reason for Linux failing while appveyor / MSYS2 not failing is that
this check is defined different for a WIN32 system as for the other systems.
The reason for this is unknown to
The proposal to merge lp:~widelands-dev/widelands/scotty_the_scout into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/scotty_the_scout/+merge/362943
--
Your team Widelands Developers is subscribed to
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/362944
--
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/bug-memleak-net-ui into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-memleak-net-ui/+merge/362945
--
Your team Widelands Developers is requested
:-( Sorry GunChleoc. I'm going to relink them later.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/362944
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list:
Set it to true. Thanks kaputtnik.
--
https://code.launchpad.net/~widelands-dev/widelands/coroutine-error-collectors/+merge/362956
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/coroutine-error-collectors into lp:widelands.
I didn't know about this as I use a MSYS2 Environment (like Appveyor) where it
compiled and worked.
Unfortunately my C++ knowledge is very limited, so I am not sure how to fix
this.
If anyone of you knows what is going on there feel free to correct it. I will
try to do so as well tonight.
Memory leak and fix confirmed. Code LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-memleak-net-ui/+merge/362945
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-memleak-net-ui into lp:widelands.
I also think that it should pop up.
--
https://code.launchpad.net/~widelands-dev/widelands/coroutine-error-collectors/+merge/362956
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/coroutine-error-collectors into lp:widelands.
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/scotty_the_scout/+merge/362943
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/scotty_the_scout.
___
Mailing list:
The bugs are related to the branch because this is a permanent branch that I
keep recycling. Just like the bugs that are linked to trunk, they should have
remained linked.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/362944
Your team Widelands
19 matches
Mail list logo
