Added some nits for strings and comments.
The grouping doesn't work properly. In
http://alpha.widelands.org/forum/latest_posts/?days=400_by=forum
I see the "Germany" forum twice and the topic "Na dann gucken wir mal wie das
hier ist" 3 times.
In
Text looks good, Can you make it translatable, please?
pgettext("atlanteans_building", text)
Let's have it for Build 21 so we won't break string freeze again.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-document-mill/+merge/364704
Your team Widelands Developers is
Continuous integration builds have changed state:
Travis build 4610. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/508054518.
Appveyor build 4397. State: success. Details:
Continuous integration builds have changed state:
Travis build 4609. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/508054226.
Appveyor build 4396. State: failed. Details:
The proposal to merge lp:~widelands-dev/widelands-website/more_latest_posts
into lp:widelands-website has been updated.
Description changed to:
Add a view to show more 'latest posts'
- Add a link to the bottom of the 'Latest Posts' box
- Add a view showing the latest posts
- Add a form to
The proposal to merge lp:~widelands-dev/widelands-website/more_latest_posts
into lp:widelands-website has been updated.
Description changed to:
Add a view to show more 'latest posts'
- Add a link to the bottom of the 'Latest Posts' box
- Add a view showing the latest posts
- Add a form to
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/more_latest_posts into lp:widelands-website.
Commit message:
Add a 'more latest posts view'
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1635676 in Widelands Website: "Last posts didn't show
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1820036-map-saving-prompt into lp:widelands.
Commit message:
After successfully saving a map, mark it as not needing saving.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1820036 in widelands:
The proposal to merge lp:~widelands-dev/widelands/bug-1809838-blackroot-target
into lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1809838-blackroot-target/+merge/361290
--
Your team Widelands
Notabilis has proposed merging
lp:~widelands-dev/widelands/bug-1809838-document-mill into lp:widelands.
Commit message:
Documenting "strange" behavior of atlanteans mill for players.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1809838 in widelands: "Blackroot
The proposal to merge lp:~widelands-dev/widelands/barracks_graphics into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/barracks_graphics/+merge/364404
--
Your team Widelands Developers is requested
The usual inputqueues timeout on test suite with GCC8
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/barracks_graphics/+merge/364404
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/barracks_graphics into
CMake failure on OSX; everything else is green.
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665
Your team Widelands Developers is requested to review the proposed merge of
The proposal to merge lp:~widelands-dev/widelands/changelog_201902 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
--
Your team Widelands Developers is subscribed to
Review: Approve
travis inputqueue test timeout in one build only
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/changelog_201902.
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 4603. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/507741639.
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
Your team
Continuous integration builds have changed state:
Travis build 4603. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/507741639.
Appveyor build 4390. State: success. Details:
Diff comments:
> === modified file 'src/economy/roadbase.cc'
> --- src/economy/roadbase.cc 2019-03-12 12:11:23 +
> +++ src/economy/roadbase.cc 2019-03-12 12:11:50 +
> @@ -69,6 +71,68 @@
> return *flags_[FlagStart];
> }
>
> +// This returns true if and only if this is a
Agreed. Let'd do a status update for the latest changes with the Winter Freeze,
and then a summarized overall announcement for the RC or release.
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
Your team Widelands Developers is requested to review the
Replied to diff comments
Diff comments:
> === modified file 'src/economy/roadbase.cc'
> --- src/economy/roadbase.cc 2019-03-12 12:11:23 +
> +++ src/economy/roadbase.cc 2019-03-12 12:11:50 +
> @@ -69,6 +71,68 @@
> return *flags_[FlagStart];
> }
>
> +// This returns true if
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805508-burning-military-sites/+merge/364665
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into
lp:widelands.
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1805508-burning-military-sites into
lp:widelands.
Commit message:
When a medium military building is conquered, small military buildings very
close to it burn down without a fight. When multiple small military buildings
are burned
Some code review comments
Diff comments:
> === modified file 'src/economy/roadbase.cc'
> --- src/economy/roadbase.cc 2019-03-12 12:11:23 +
> +++ src/economy/roadbase.cc 2019-03-12 12:11:50 +
> @@ -69,6 +71,68 @@
> return *flags_[FlagStart];
> }
>
> +// This returns true if
Agreed. we should wait with the development post for having the RC Though so we
can combine the two messages. Most of the features have been reported in the
last update (feature freeze) anyhow.
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
Your team
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 4600. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/506014328.
--
https://code.launchpad.net/~widelands-dev/widelands/barracks_graphics/+merge/364404
Your team
The proposal to merge lp:~widelands-dev/widelands/worker_fetchfromflag_crash
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/worker_fetchfromflag_crash/+merge/364650
--
Your team Widelands
@hessenfarmer: Thanks a lot four your help.
Let's merge this now, leave the bug open and do a follow-up branch when we are
ready to tag the RC.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_201902/+merge/364658
Your team Widelands Developers is requested to
GunChleoc has proposed merging lp:~widelands-dev/widelands/changelog_201902
into lp:widelands.
Commit message:
Updated changelog up to bzr9007
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1817841 in widelands: "Change log for Build 20 RC1"
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/barracks_graphics/+merge/364404
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/barracks_graphics into lp:widelands.
___
Review: Approve
Thanks for fixing :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/worker_fetchfromflag_crash/+merge/364650
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/worker_fetchfromflag_crash.
30 matches
Mail list logo
