Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread TiborB
Was you considering making barracks a recruitment? Because preciousness of barracks (output) is now hardcoded to 5, if I am right. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preciousness/+merge/367608 Your team Widelands Developers is requested to review the propos

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-05-18 Thread Klaus Halfmann
Review: Needs Fixing testplay I played Calvission again fo about 4 hours gametime. This was fine for the most parts, I found some of the expected Issued: e.g. Buildings not attachted to roads dont get workers. I found one Issue where ferries are not built. But now I hit an seertion that should be

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread bunnybot
Continuous integration builds have changed state: Travis build 5015. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/534229981. Appveyor build 4796. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182947

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread TiborB
I am getting the failing assert for atlanteans horsefarm and barbarian cattlefarm - in trunk... They have max_needed_preciousness 1. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preciousness/+merge/367608 Your team Widelands Developers is requested to review the propo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-05-18 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929 -- Your team Widelands Developers is

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-05-18 Thread bunnybot
Continuous integration builds have changed state: Travis build 5013. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/534168690. Appveyor build 4794. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_per_level

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread TiborB
I will investigate that assert -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preciousness/+merge/367608 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread GunChleoc
BTW that assert is already broken in trunk. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preciousness/+merge/367608 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:wideland

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-05-18 Thread GunChleoc
The inputqueues failed again @bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/per-level-soldier-anims. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread GunChleoc
Thanks, that fixed it! There should be no real impact on training from this branch. This is a pure refactoring without any intended semantic changes except that the reindeer farm now has a minimum preciousness of 2. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preci

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread TiborB
The logic is / was you cannot have max preciousness if you do not produce anything... -- https://code.launchpad.net/~widelands-dev/widelands/bug-1829471-worker-preciousness/+merge/367608 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread TiborB
See my comments below BTW I am doing some training, I hope this will not interfere. Once it is merged, I will re-train too.. Diff comments: > > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2019-05-17 11:45:39 + > +++ src/ai/defaultai.cc 2019-05-18 13:37:09

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands

2019-05-18 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1829471-worker-preciousness into lp:widelands. Commit message: Some AI code cleanups - Implement AI hints for workers - Deduce whether a building is a barracks or recruits other workers from building outputs - Move ware preciousness

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-05-18 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 4966. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/531659623. -- https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929 Your t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-05-18 Thread GunChleoc
Review: Approve Testing done. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/per-level-soldier-anims. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/localization-post-build20 into lp:widelands

2019-05-18 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/localization-post-build20 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/localization-post-build20/+merge/367305 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818013-new-logo into lp:widelands

2019-05-18 Thread GunChleoc
Any objections to merging this? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1818013-new-logo/+merge/366502 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1818013-new-logo into lp:widelands. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/localization-post-build20 into lp:widelands

2019-05-18 Thread GunChleoc
Yes, that's https://bugs.launchpad.net/widelands/+bug/1827544 Thanks for the review :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/localization-post-build20/+merge/367305 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/localization-p