Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-06-15 Thread TiborB
I am thinking a lot about this feature, but for AI it is relay difficult. On most maps it will not be applicable and AI should be very cautious to use it at all. It has complex logic for implementation. So the conclusion is that it is not worth the effort to implement in AI. What could be consi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1830868-skip-tests into lp:widelands

2019-06-15 Thread bunnybot
Continuous integration builds have changed state: Travis build 5195. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/546082615. Appveyor build 4975. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18308

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1830868-skip-tests into lp:widelands

2019-06-15 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1830868-skip-tests into lp:widelands. Commit message: Adding compile.sh switch -s to skip building the tests. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1830868 in widelands: "Add switch to compile

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-06-15 Thread Benedikt Straub
Whether waterways/ferries are enabled can be checked as map.get_waterway_max_length() >= 2 Typically, they are enabled only on maps where they make sense. Waterways have a maximum length that is map-dependent. If two flags can be connected both by a new road and by a new waterway, the AI shou

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1826744-lobby-commands into lp:widelands

2019-06-15 Thread Notabilis
Thanks for the reviews. A metaserver branch with the requested change is open at https://github.com/widelands/widelands_metaserver/pull/60 and already deployed for testing. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1826744-lobby-commands/+merge/368285 Your team Widelands Develop