Review: Needs Fixing regression tests
We have a lot of regressiontests about seafaring (for a reason :-)
./regression_test.py -b ./widelands
FAILs
test/maps/ship_transportation.wmf/scripting/test_rip_ports_with_worker_in_transit.lua
...
test/maps/ship_transportation.wmf/scripting/test_rip_fir
Did a first review, the code is ok, but some more comments
would help me to grasp me the semantics of some stuctures.
and please refactor out some of the bigger loops.
(https://de.wikipedia.org/wiki/Refactoring)
Please check my inline comments.
Do you have an idea how big the perfomance impact ma
Thanks for picking this up, as I am just teesting some new Mpa with
a lot of Ports, I can combine two things here. I dont have that much
time the next weeks, though.
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is requested to re
Continuous integration builds have changed state:
Travis build 5309. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/570269198.
Appveyor build 5082. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_new_shippin
> Other extensions that we're using for Widelands & that might be interesting:
> .wai - AI
Ok
> .wmf - Map
I forgot to mention: If the extension is wmf, an errormessage is shown: "This
seems to be a widelands map file. Please upload it at our maps section."
> .wrpl - Replay - useless with the
I think it's just Launchpad or Bunnybot getting confused because of the
unmerged prerequisite in their messages. The code in trunk is fine - the new UI
test got added. which means that the correct branch was merged.
clang-format separated some translators' comments from their strings though, so
Gun: now this got merged, what kind of accident was this?
--
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-scripting-review-only/+merge/368228
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/toolbar-dropdown-scripting-
The proposal to merge lp:~widelands-dev/widelands/toolbar-dropdown-menus into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230
--
Your team Widelands Developers is su
The proposal to merge
lp:~widelands-dev/widelands/toolbar-dropdown-scripting-review-only into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-scripting-review-only/+merge/368228
--
You
Continuous integration builds have changed state:
Travis build 5306. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/570176875.
Appveyor build 5079. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_toolbar_dr
2. I have no opinion on this at this time. Maybe 10 or 20? We can easily change
the value if it becomes a problem.
> Files without extension aren't allowed (can be problematic e.g. with the
> campvis file)
campvis will be replaced by campaigns.conf for the next version, so don't worry
about it
The reason that the test failed was because there is a UI test that depends on
"buildhelp" to be a button, which is a menu entry now. I have changed it to use
"help" instead, which is the button for opening the Encyclopedia.
The second failure was that in debug builds, the main menu has 1 additi
Review: Approve comile, regression test
Fine onn OSX now, too (release build)
> Ran 45 tests in 1128.847s
> OK
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wi
I am a bit lost here...
Some checks are made now, but i am unsure if we need them all. What is
implemented:
1. Link of Attachment:
If a user clicks on a link of an attachment, he will be ever prompted for a
download (or to open the file with an associated program), even if it is a file
which t
Review: Approve compile, regression test
Ahh, now you confused me :-)
Just tried on Linux
> Linux iXubuntu 5.0.0-23-generic #24-Ubuntu SMP Mon Jul 29 15:36:44 UTC 2019
> x86_64 x86_64 x86_64 GNU/Linux
and suprise: al Regreession tests pass on this branch and trunk with release
and debug
OK
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/new-shipping
into lp:widelands.
Commit message:
New planning-ahead ship scheduling algorithm
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1827033 in widelands: "Bugs in new ShipScheduling algorithm
Running tests locally I get (on OSX):
FAIL: test_buttons_property: [string "scripting/ui.lua"]:26: 'nil' not expected!
FAIL: test_name: [string "scripting/ui.lua"]:113: attempt to index a nil value
(field 'b')
stack traceback:
[string "scripting/ui.lua"]:113: in upvalue 'func'
[s
Review: Needs Fixing
Mhh, some travis builds just time out,
The Realse Builds are all broekn with a testcase.
https://travis-ci.org/widelands/widelands/jobs/569957376
1383 Assertions checked. 405 Tests passed, 3 failed!
Trying to run: test/maps/lua_testsuite.wmf/scripting/test_lua_in_game.lua: d
18 matches
Mail list logo
