[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands

2019-09-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 5391. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/581403115. Appveyor build 5161. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_184239

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands

2019-09-05 Thread Notabilis
Sounds got to me, the changes are online. Thanks for the reviews! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1842396-no-tribe. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 -- Your team Widelands Developers is su

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 5389. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/581267547. Appveyor build 5159. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_co

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread hessenfarmer
Hm I still get the following error in a release build. Unexpected error during the game vector::_M_range_check: __n (which is 255) >= this->size() (which is 131) will install a debug build now -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team W

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-09-05 Thread kaputtnik
Looks like the metal workshop 'hangs', it always shows 'The Economy doesn't need the ware Bradpaddle', although the game run more than 5 Minutes. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
Review: Approve @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/amazons-coding-changes. ___ Mailing list: ht

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
Review: Approve Looks like the crash has been identified: https://www.widelands.org/forum/topic/2897/?page=11#post-29630 So, this is a data issue unrelated to this branch. I'll revert the tribes and merge. -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands has been updated. Commit message changed to: Implements the coding changes required for the new amazons tribe: - findspace:swim (for water gatherers) - Enhancing terrains (for gardening center) - Construct

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/new-shipping into lp:widelands

2019-09-05 Thread GunChleoc
I have added some comments Diff comments: > > === modified file 'src/logic/map_objects/tribes/ship.cc' > --- src/logic/map_objects/tribes/ship.cc 2019-05-27 14:28:34 + > +++ src/logic/map_objects/tribes/ship.cc 2019-09-03 15:47:16 + > @@ -736,22 +736,215 @@ > } > } > >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1842396-no-tribe into lp:widelands

2019-09-05 Thread GunChleoc
I think we should fix all of them. How about sticking them into a new function bool has_players_tribe() in game_settings.h? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread TiborB
try with gdb if you can -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/amazons-coding-changes. ___ Mailing list: https:/