The proposal to merge lp:~thenifker13/widelands/trunk into lp:widelands has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~thenifker13/widelands/trunk/+merge/368235
--
Your team Widelands Developers is requested to review the propos
Migrated to https://github.com/widelands/widelands/tree/windows-esc
--
https://code.launchpad.net/~thenifker13/widelands/trunk/+merge/368235
Your team Widelands Developers is requested to review the proposed merge of
lp:~thenifker13/widelands/trunk into lp:widelands.
The proposal to merge lp:~widelands-dev/widelands/spritesheet_generation into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/spritesheet_generation/+merge/370824
--
Your team Widelands Develo
The proposal to merge lp:~widelands-dev/widelands/refactor_gamehost into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320
--
Your team Widelands Developers is su
The proposal to merge lp:~widelands-dev/widelands/new-shipping into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
--
Your team Widelands Developers is subscribed t
The proposal to merge lp:~widelands-dev/widelands/bridges into lp:widelands has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bridges/+merge/364318
--
Your team Widelands Developers is subscribed to branch
The proposal to merge lp:~widelands-dev/widelands/fix-cmakelists-codecheck into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix-cmakelists-codecheck/+merge/372114
--
Your team Widelands De
The proposal to merge lp:~widelands-dev/widelands/ferry into lp:widelands has
been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
--
Your team Widelands Developers is subscribed to branch
lp:~
Pull request: https://github.com/widelands/widelands/pull/3479
--
https://code.launchpad.net/~widelands-dev/widelands/bug-794407-soldier-stats/+merge/371952
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-794407-soldier-stats into lp:wid
The proposal to merge lp:~widelands-dev/widelands/bug-794407-soldier-stats into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-794407-soldier-stats/+merge/371952
--
Your team Widelands De
The proposal to merge
lp:~widelands-dev/widelands/bug-1841471-close-dropdowns-with-parent-windows
into lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1841471-close-dropdowns-with-parent-w
The proposal to merge lp:~widelands-dev/widelands/bug-1828355-windows-localedir
into lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1828355-windows-localedir/+merge/367938
--
Your team Wi
Migrated to https://github.com/widelands/widelands/pull/3477
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1828355-windows-localedir/+merge/367938
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1828355-windows-localedir int
The proposal to merge lp:~widelands-dev/widelands/balancing-201908 into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/balancing-201908/+merge/371947
--
Your team Widelands Developers is requ
I need this for the move to GitHub, so I'll merge without review.
--
https://code.launchpad.net/~widelands-dev/widelands/changelog-9201/+merge/372450
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/changelog-9201 into lp:widelands.
You have been requested to review the proposed merge of
lp:~thenifker13/widelands/trunk into lp:widelands.
For more details, see:
https://code.launchpad.net/~thenifker13/widelands/trunk/+merge/368235
Window closing, opening OptionsMenu and exiting using the keyboard.
--
Your team Widelands Dev
GunChleoc has proposed merging lp:~widelands-dev/widelands/changelog-9201 into
lp:widelands.
Commit message:
Updated changelog to bzr9201
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/changelog-9201/+merge
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/relax-ai-asserts.
___
Mailing list: https
Fix confirmed :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
___
Mailing list:
This does not work for minimized windows, they still stay minimzed.
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
___
Review: Approve
I can't think of a cleaner solution either at this point, so code LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/372447
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
LAN or Internet game?
--
https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/refactor_gamehost.
___
Mailing list: https://launchpad.net/~
Thanks again!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler-warnings-201908-2.
___
Mailing li
The UI test sometimes fails because it takes too long for the game to close. I
have implemented a fix in one of my other branches. Will rerun the Travis job.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribe
Thanks for the review!
I already did a code review on your branch, I guess you overlooked it.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compil
You just asked for a review. See my comment above.
--
https://code.launchpad.net/~widelands-dev/widelands/refactor_gamehost/+merge/370320
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/refactor_gamehost into lp:widelands.
_
The proposal to merge lp:~widelands-dev/widelands/relax-ai-asserts into
lp:widelands has been updated.
Commit message changed to:
Some improvements around AI asserts
- Relax AI requirement for hunters
- Be more informative when building is missing the
"collects_ware_from_map" AI hint
For mor
Hm, at this point I'm wondering whether it might be easier to allow ferries to
carry workers and have them waiting for it at the nearest flag. Then we would
not need the separate economies.
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers
GunChleoc has proposed merging lp:~widelands-dev/widelands/relax-ai-asserts
into lp:widelands.
Commit message:
Relax AI requirement for hunters.
Requested reviews:
TiborB (tiborb95)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/relax-ai-asserts/+merge/372400
Review: Approve
Thanks for fixing :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1842396-no-tribe.
__
Review: Approve
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/amazons-coding-changes.
___
Mailing list: ht
Review: Approve
Looks like the crash has been identified:
https://www.widelands.org/forum/topic/2897/?page=11#post-29630
So, this is a data issue unrelated to this branch.
I'll revert the tribes and merge.
--
https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371
The proposal to merge lp:~widelands-dev/widelands/amazons-coding-changes into
lp:widelands has been updated.
Commit message changed to:
Implements the coding changes required for the new amazons tribe:
- findspace:swim (for water gatherers)
- Enhancing terrains (for gardening center)
- Construct
I have added some comments
Diff comments:
>
> === modified file 'src/logic/map_objects/tribes/ship.cc'
> --- src/logic/map_objects/tribes/ship.cc 2019-05-27 14:28:34 +
> +++ src/logic/map_objects/tribes/ship.cc 2019-09-03 15:47:16 +
> @@ -736,22 +736,215 @@
> }
> }
>
>
I think we should fix all of them. How about sticking them into a new function
bool has_players_tribe() in game_settings.h?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands
The proposal to merge lp:~widelands-dev/widelands/emp_4_fixes into lp:widelands
has been updated.
Commit message changed to:
Fixes to Empire scenario 4
- small trainingcamp is now buildable although at very high costs. (it is not
intended the player should stay with them)
- first objective don
The proposal to merge lp:~widelands-dev/widelands/emp_4_fixes into lp:widelands
has been updated.
Description changed to:
fixes issues described in
https://www.widelands.org/forum/topic/4617/?page=1#post-29597
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/emp_4_fix
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/emp_4_fixes/+merge/372196
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/emp_4_fixes.
___
Mailing list: https://launchp
Review: Approve
Thanks for fixing :)
Wouldn't it be better to use if(Widelands::tribe_exists(tribename)) rather than
triggering the exception?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1842396-no-tribe/+merge/372281
Your team Widelands Developers is subscribed to branch
lp:~wi
When I have 2 economies only liked by a waterway, the metal workshop won't
produce the necessary wares - I expect the request is generated by the wrong
warehouse.
Savegame: https://bugs.launchpad.net/widelands/+bug/1584203/comments/50
--
https://code.launchpad.net/~widelands-dev/widelands/ferry
And another thing that can be improved in checkstep, but will probably be
non-trivial:
https://bugs.launchpad.net/widelands/+bug/1584203/comments/48
I'd be OK with doing this in a follow-up branch.
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands De
I have pushed a commit that shuts up clang compiler warnings, so you need to
pull before continuing to work.
I think that Checkstep should ignore waterways that don't have ferries - I have
attached a savegame to illustrate the issue.
https://bugs.launchpad.net/widelands/+bug/1584203/comments/47
I have marked all official maps that didn't have an "unbalanced" tag as
"balanced"
--
https://code.launchpad.net/~widelands-dev/widelands/map-filter-dropdowns/+merge/372159
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/map-filter-dropdown
With the upcoming ferry branch, we will run out of screen space for map tags.
So, I have grouped them into dropdown menus.
--
https://code.launchpad.net/~widelands-dev/widelands/map-filter-dropdowns/+merge/372159
Your team Widelands Developers is requested to review the proposed merge of
lp:~wid
You can test this by adding a dependency to a library that doesn't use it in
one of the CMakeLists.txt files, or by deleting a dependency.
--
https://code.launchpad.net/~widelands-dev/widelands/fix-cmakelists-codecheck/+merge/372114
Your team Widelands Developers is requested to review the propos
The proposal to merge lp:~widelands-dev/widelands/unify-program-parsers into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936
--
Your team Widelands Develope
I can reproduce the problem now in an Ubuntu trusty VM.
--
https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/list-directories-in-cpp.
_
Review: Resubmit
I'm done checking the logs, so this is ready for review now.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler-warnings-201908-2.
__
Review: Approve
Thanks!
I have done some final cleanup, so this can go in now :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_ga_unittests/+merge/372091
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_ga_unittests.
___
GunChleoc has proposed merging
lp:~widelands-dev/widelands/fix-cmakelists-codecheck into lp:widelands.
Commit message:
Dependency check doesn't work with ninja, so we run it manually from compile.sh
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
I have pushed a commit with a comment.
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ferry.
___
Mailing list: https://launchpad.net/~widelan
GunChleoc has proposed merging
lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands.
Commit message:
Fix compiler warnings and refactor config dir.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev
LGTM :)
Just 1 tiny nit: What does ga mean? Add a comment to the test file.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_ga_unittests/+merge/372091
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelan
Review: Approve
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_wai_files_29082019/+merge/372083
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_wai_files_29082019.
___
Mailing l
Thanks for the review!
I'll be going through the Travis/Appveyor logs to see if I can find more stuff
to fix.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908/+merge/372109
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler
GunChleoc has proposed merging
lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands.
Commit message:
Fix compiler warnings.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings
The proposal to merge lp:~widelands-dev/widelands/spritesheet_generation into
lp:widelands has been updated.
Description changed to:
Spritesheets :)
Note that the idle carrier gets a black background when zoomed out - this is a
proof-of-concept that the correct mipmap files are being generated
I have pushed another commit with code review. I'm done with this for now. I
also did a grep on data and test for lua changes, and it looks like we didn't
miss anything.
The following 2 bits in the code are a bit complicated and could do with
testing:
* worker creation over multiple economies
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1841471-close-dropdowns-with-parent-windows
into lp:widelands.
Commit message:
Fix deleting of dropdown lists in UniqueWindow and Player Menu.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1841471
I have pushed a new commit with a code style review. I'll have to return later
to go through the discussion.
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ferry.
_
I had a look at the check for disallowing double colonization. I think it would
be sufficient to check whether there's a building there, we don't care if it's
a port or a construction site. It might even be safer, because the enemy might
also have been faster with building something there.
--
h
The proposal to merge lp:~widelands-dev/widelands/bug-794407-soldier-stats into
lp:widelands has been updated.
Commit message changed to:
Improve soldier level graphics and chat menu code
- Improve visibility of health bar graphs
- Add toggle for soldier level/health bar graphics
- Indicate in b
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-794407-soldier-stats into lp:widelands.
Commit message:
Improve soldier level graphics and chat menu code
- Improve visibility of health bar graphs
- Add toggle for soldier level/health bar graphics
- Small refactoring for cat menu
The proposal to merge lp:~widelands-dev/widelands/bug-794407-soldier-stats into
lp:widelands has been updated.
Commit message changed to:
Improve soldier level graphics and chat menu code
- Improve visibility of health bar graphs
- Add toggle for soldier level/health bar graphics
- Indicate in b
GunChleoc has proposed merging lp:~widelands-dev/widelands/balancing-201908
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/balancing-201908/+merge/371947
Test changes suggested in https
I have done a first round of code review, no testing yet.
Diff comments:
>
> === modified file 'src/editor/tools/delete_critter_tool.cc'
> --- src/editor/tools/delete_critter_tool.cc 2019-02-23 11:00:49 +
> +++ src/editor/tools/delete_critter_tool.cc 2019-08-23 14:48:43 +
> @@ -41,7
Review: Approve
I have tested map upload and attaching to forum.
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list
No, I still need to find the bug that occurs with some compilers.
--
https://code.launchpad.net/~widelands-dev/widelands/unify-program-parsers/+merge/367936
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/list-directories-in-cpp.
___
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/cleanup_playercommand_enums/+merge/369267
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/cleanup_playercommand_enums.
___
Mailing list: https://l
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/productionsite-inactivity-bug/+merge/371423
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/productionsite-inactivity-bug.
_
1 tiny nit.
I also wonder whether we should disallow map files - it might come in handy if
somebody wants some feedback before publishing to the maps section.
Diff comments:
>
> === modified file 'pybb/util.py'
> --- pybb/util.py 2019-04-11 15:20:33 +
> +++ pybb/util.py 2019-08-1
Review: Approve
Yes, much better! :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/atlanteans_cornfield/+merge/371209
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/atlanteans_cornfield.
__
Review: Approve
OK, let's have it then :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
___
LGTM :)
Do we want to disable the save button too?
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands.
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/workarea-fixes/+merge/371171
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/workarea-fixes.
___
Mailing list: https://l
Code LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/371170
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/constructionsite_options into lp:widelands.
Review: Approve
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/new_wai_files_11082019/+merge/371178
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/new_wai_files_11082019.
___
Mailing
I think it's just Launchpad or Bunnybot getting confused because of the
unmerged prerequisite in their messages. The code in trunk is fine - the new UI
test got added. which means that the correct branch was merged.
clang-format separated some translators' comments from their strings though, so
2. I have no opinion on this at this time. Maybe 10 or 20? We can easily change
the value if it becomes a problem.
> Files without extension aren't allowed (can be problematic e.g. with the
> campvis file)
campvis will be replaced by campaigns.conf for the next version, so don't worry
about it
The reason that the test failed was because there is a UI test that depends on
"buildhelp" to be a button, which is a menu entry now. I have changed it to use
"help" instead, which is the button for opening the Encyclopedia.
The second failure was that in debug builds, the main menu has 1 additi
Thanks for testing again!
Shall we meet on the forum for discussing any improvements that can be made to
the user interaction? https://www.widelands.org/forum/topic/2769/
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230
Your team Widela
Review: Approve
Very nice indeed :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/toc_to_latest_posts/+merge/370906
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~w
Thanks for testing!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/gcc9/+merge/370692
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/gcc9.
___
Mailing list: https://launchpad.net/~widelands-d
Looking good, let's have it :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/ai_flag_warehouse_distance/+merge/368544
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_flag_warehouse_distance.
_
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1838193-savedir/+merge/370829
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1838193-savedir into lp:widelands.
___
All issues mentioned in this discussion should be fixed now, except for loading
a Tutorial 2 game, which I cannot reproduce. I don't expect that it has
anything to do with this branch though, since I get similar messages for Build
20 games in trunk.
--
https://code.launchpad.net/~widelands-dev/
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1838193-savedir
into lp:widelands.
Commit message:
Ensure save directory exists when checking for campaigns progress.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1838193 in widelands: "S
Jobs are green on AppVeyor - can somebody with a Windows machine please test
before we merge?
https://ci.appveyor.com/project/widelands-dev/widelands/builds/26365811
--
https://code.launchpad.net/~widelands-dev/widelands/gcc9/+merge/370692
Your team Widelands Developers is requested to review t
Code review done. Mostly small tweaks to names and some efficiency stuff, and 1
real question.
Diff comments:
>
> === modified file 'src/ai/ai_help_structs.cc'
> --- src/ai/ai_help_structs.cc 2019-04-09 16:43:49 +
> +++ src/ai/ai_help_structs.cc 2019-07-24 19:32:22 +
> @@ -1417,4 +1301,
Pause does not work in network games; the host has to use a chat command for
that. Good catch - I'll remove pause game from the menu for multiplayer games.
We could always open multiple editor windows, so this is not new.
--
https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-me
> Everyone can rename 'image.js' into 'image.png'...
That's true. It would still be an advantage though if the browser then doesn't
execute it.
Doing a full validation too is definitely a better idea.
> What about restricting uploads to users who have written x posts prior?
Also a good idea
-
Thanks, Tino!
I have applied your changes to this branch now.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc9/+merge/370692
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/gcc9 into lp:widelands.
___
Probably - I haven't looked into that yet.
--
https://code.launchpad.net/~widelands-dev/widelands/gcc9/+merge/370692
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/gcc9 into lp:widelands.
___
Mai
I have fixed the map keyboard navigation by no longer opening the dropdowns'
lists with the Up/Down keys. I don't think this is being used anyway.
I have played tutorial 2 on this branch and then loaded all the automatically
generated saves without any problems.
Issues to still look into:
- Op
GunChleoc has proposed merging lp:~widelands-dev/widelands/gcc9 into
lp:widelands.
Commit message:
Patch for GCC9.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1831359 in widelands: "Implement support for GCC 9"
https://bugs.launchpad.net/wide
ids.h 2019-06-24 22:00:34 +
> @@ -33,17 +33,21 @@
>
> namespace Widelands {
>
> -enum class QueueCommandTypes {
> +// The command types are used by the QueueCmdFactory, for network
> serialization
> +// and for savegame compatibility.
> +// DO NOT change the
gt; + // the client might just have had bad luck with the timing.
> + if (!d->game) {
> + uint8_t num = r.unsigned_8();
> + if (num != client.playernum)
> + throw DisconnectException("NO_ACCESS_TO_PLAYER");
> + set_play
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands-website/sitemap_https/+merge/370398
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug_1836107_lGL/+merge/370334
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug_1836107_lGL.
___
Mailing list: https://launchpad.net/~wideland
Code LGTM. Do we have a restriction on file types? We won't want people to
upload malicious JavaScript ans stuff lie that, so we should have a list of
legal file extensions at least.
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands
1 - 100 of 4401 matches
Mail list logo
