Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1503949 into lp:widelands

Now that the regression test is green again in trunk, it also does not fail anymore in this branch. -- https://code.launchpad.net/~widelands-dev/widelands/bug1503949/+merge/274157 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1503949.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1503949 into lp:widelands

By the way, I also did some (very tedious) Valgrind sessions to check that no memory is lost during loading. -- https://code.launchpad.net/~widelands-dev/widelands/bug1503949/+merge/274157 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1503949. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1503949 into lp:widelands

I took the information that is_loaded could be correct from its description: /** * \return \c true if the game is completely loaded and running (or paused) * or \c false otherwise. */ Also, I had logging messages (which I removed before committing) in both bra

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1503949 into lp:widelands

No, but now I did, and it fails the same test only as trunk: Bug 1506084 -- https://code.launchpad.net/~widelands-dev/widelands/bug1503949/+merge/274157 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug1503949 into lp:widelands. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1480928 into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/bug1480928 into lp:widelands has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug1480928/+merge/270540 -- Your team Widelands Developers is subscribed to branch lp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504948 into lp:widelands

I tested with a modified production site program for the shipyard - first do the building of the ship, then check for seafaring. This way whenever the shipbuilding is called, the program consumes a ware. Now when I removed all wares from stock, the "no use for ships on this map" was coming up. W

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1503949 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1503949 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1503949 in widelands: "excessive CPU usage and loading time seemingly related to lenght of the game&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504952 into lp:widelands

I could have done that, but after my being too eager with the other merge request, I am now pushing everything separately :-) Regarding the new push... yes, I am really good at that "push first, compile later" game... but I usually stop before the "go on vacation" part ;-) -- https://code.launc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504952 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1504952 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1504952 in widelands: ""No use for ships on this map!" message is not translateable" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504948 into lp:widelands

I don't know if it "recovers" successfully if the map magically gets a reachable portspace (scripting/events?) after the shipyard has been built, but I am not able to create a map to test that, unfortunately. -- https://code.launchpad.net/~widelands-dev/widelands/bug1504948/+merge/274076 Your te

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504948 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1504948 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1504948 in widelands: "Performance issue when "no use for ships on this map"" https://bugs.launchpa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504366 into lp:widelands

On a second look, maybe I was a bit too eager on the MAX_PLAYERS thing, and I could take that part back, but on the other hand, it still looks like it would never happen to be something over MAX_PLAYERS... well, you decide :-) I tested again and don't see any issues. I found a new issue (when 8

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1504366 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1504366 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1504366 in widelands: "editor crashes unexpectedly" https://bugs.launchpad.net/widelands/+bug/1504366 For more de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1438611 into lp:widelands

It is not a matter of "want", but of "can" :-P I tried, and failed miserably. So I just left the TODO as requested ;-) -- https://code.launchpad.net/~widelands-dev/widelands/bug1438611/+merge/273449 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1438611. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1438611 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1438611 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1438611 in widelands: "Widelands is leaking memory" https://bugs.launchpad.net/widelands/+bug/1438611 For more de

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1502458 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1502458 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1502458 in widelands: "Carrier hiding in Warehouse/HQ is hardcoded" https://bugs.launchpad.net/widelands/+bug/15

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug580923 into lp:widelands

Hi TiborB, thanks for looking into it. For the reason of the change, please have a look at the related bug ( https://bugs.launchpad.net/widelands/+bug/580923 ), SirVer states it quite clearly, it is not a bug for Widelands (Game), but for Widelands (Engine), and there have been people (includin

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug580923 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug580923 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #580923 in widelands: "Production of carrier does not respect building costs" https://bugs.launchpad.net/widelands/+

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1480928 into lp:widelands

Review: Resubmit -- https://code.launchpad.net/~widelands-dev/widelands/bug1480928/+merge/270540 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1480928. ___ Mailing list: https://launchpad.net/~widelands-dev Pos

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1480928 into lp:widelands

Or, by cutting the animation one whole picture (=0.1s) earlier and making the lumberjacks idle more the same amount of time to prevent changing balancing. Please test again if this is feasible approach. I have tested with different game FPS settings (99, 60, 25, 8) and I don't see the issue anym

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1480928 into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/bug1480928 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1480928 in widelands: "Lumberjack animation glitches" https://bugs.launchpad.net/widelands/+bug/1480928 For mo

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1342228 into lp:widelands

Jens Beyer has proposed merging lp:~qcumber-some/widelands/bug1342228 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~qcumber-some/widelands/bug1342228/+merge/229829 Ok this is a start. Now the build always builds

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/cmake-unclutter into lp:widelands

Jens Beyer has proposed merging lp:~qcumber-some/widelands/cmake-unclutter into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~qcumber-some/widelands/cmake-unclutter/+merge/226602 Leaving this here for your judgement

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmake-reworked into lp:widelands

Not sure if this is the right place for this command, regarding the cmake-2.8.12.1 problem: The problem is caused by target_include_directories with the SYSTEM keyword. cmake-2.8.11 (saucy) does not have it. As far as I understand, the SYSTEM keyword is nothing serious for making it work at all

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cmake-reworked into lp:widelands

> I think this is now good to go. Shevonar, can you test on Linux again? I'll > merge this tomorrow if nobody cries out right now :). I am not sure, but this branch does not compile on my Linux amd64 with gcc 4.7.3 [ 0%] Building CXX object src/base/CMakeFiles/base_log.dir/log.cc.o c++: Fehler:

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1332856 into lp:widelands

Jens Beyer has proposed merging lp:~qcumber-some/widelands/bug1332856 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1332856 in widelands: "Regression from one_world: Crash when opening message regarding resources" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

Sorry, got distracted by 'the other life'. I say this is good enough to go on trunk. Few words: 1) We can not get rid yet of the menu.png files as they are used at other places (Editor, Messages...). Those should be targetted next. 2) I agree that I can live with the current state of the menu im

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/debian-merged-b18-3 into lp:~widelands-dev/widelands/debian

Done. We will see how the precise build turns out. :-) -- https://code.launchpad.net/~widelands-dev/widelands/debian-merged-b18-3/+merge/210502 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

I am not sure why, but the playercolors in the build menu do not work on the branch, even with trunk merged; but merging this branch into trunk makes the playercolor work in the build menu. Now I am totally confused. -- https://code.launchpad.net/~widelands-dev/widelands/buildicon_playercolors/+

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

I fixed the NOCOM. But there is one problem which was not present yesterday: The playercolors in the building menu are completely wrong. I remember that it definitely worked. What could have caused this? -- https://code.launchpad.net/~widelands-dev/widelands/buildicon_playercolors/+merge/211401

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/debian-merged-b18-3 into lp:~widelands-dev/widelands/debian

I believe there is nothing to add to hjd's analysis of the past of this topic :-) Best would be if hjd would merge this. Then we are back on par with official Debian regarding the build settings. -- https://code.launchpad.net/~widelands-dev/widelands/debian-merged-b18-3/+merge/210502 Your team

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/debian

Everything ok, the other branch is most definitely more accurate ;-) -- https://code.launchpad.net/~qcumber-some/widelands/bug1287241/+merge/209091 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/de

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

Jens Beyer has proposed merging lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #536230 in widelands: "building icons in menu are shown without correct playercolor" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

Setting rejected, I will push another merge request -- https://code.launchpad.net/~widelands-dev/widelands/buildicon_playercolors/+merge/211184 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/buildicon_playercolors. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/buildicon_playercolors/+merge/211184 -- https://code.launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/spritemaps into lp:widelands

Looks like this branch does not merge into trunk without conflicts around the Barbarian ferner? -- https://code.launchpad.net/~widelands-dev/widelands/spritemaps/+merge/211225 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/spritemaps into

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

Thanks for the review and the suggestion. Now that I have something working, it is easier for me to discuss it, so please be patient with me ;-) I did not have a look into your branch yet, but from what I think I understand, you want to use a "representative image" of the animation, which is one

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~widelands-dev/widelands/buildicon_playercolors into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #536230 in widelands: "building icons in menu are shown without correct playercolor&quo

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/debian

I asked at https://answers.launchpad.net/launchpad/+question/245296 what to do. If I interpret the answer correctly, then dh_auto_build should do the parallel building automatically even without --parallel if the build setup process configured it accordingly, which is all done automatically. Thi

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/debian

I applied the patch by Martin to the debian branch and ran the builds. While it does not seem to break anything, the builds were very slow. I can not see in the logfiles that it enables -jX for the make call. Don't know what I should make out of this... -- https://code.launchpad.net/~qcumber-som

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1167242 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug1167242 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1167242 in widelands: "Ctrl+destroying a flag with a building does not destroy the whole road&quo

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/debian

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug1287241 into lp:~widelands-dev/widelands/debian. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1287241 in widelands: "Parallel compilation on launchpad builder is broken&quo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/boost-signals2 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~widelands-dev/widelands/boost-signals2 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1201081 in widelands: "Building with boost 1.54: "Boost.Signals is no longer being maintained

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug994712 into lp:widelands

Thanks to both of you. I will add another copyright notice at the top and rewrite the last sentence to be more friendly and less legalese and then I'll merge this. -- https://code.launchpad.net/~widelands-dev/widelands/bug994712/+merge/176747 Your team Widelands Developers is subscribed to branc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1204612 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~widelands-dev/widelands/bug1204612 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1204612 in widelands: "FTBFS on Ubuntu Precise and Lucid" https://bugs.launchpad.net/widelands/+b

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug994712 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~widelands-dev/widelands/bug994712 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #994712 in widelands: "GPL Text should maybe not be translateable" https://bugs.launchpad.net/wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1204144 into lp:widelands

Review: Needs Fixing First: somehow this patch makes cursor navigation up AND down working where trunk only works for up and not for down ;-) But - some minor "problems": When choosing Single player maps, there seems to be a preference to keep the "second" visible item in the table selected. T

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1203121 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~widelands-dev/widelands/bug1203121 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1203121 in widelands: "Latest trunk FTBFS on Ubuntu 12.04 (src/helper.cc:82:8: error: 'mt19937

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cxx11 into lp:widelands

...and to make things even more interesting, it simply does not work when running cmake again. rm -r of the whole build directory, then cmake again works... So, to compile this with gcc-4.6: 1) fetch yourself a clean trunk 2) bzr merge this branch 3) rm -r everything in the build directory 4)

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cxx11 into lp:widelands

Ok I did 1) pull clean trunk 2) rm -r build/* 3) cmake;make 4) bzr merge 5) make cmake was automatically re-executed and pulled in -std=c++0x; compile was successful; game started. -- https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455 Your team Widelands Developers is requ

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cxx11 into lp:widelands

This will make use of the compile.sh script difficult... -- https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/cxx11 into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cxx11 into lp:widelands

Even more interesting, adding -std=c++0x manually and unconditionally to the compiler flags simply works... so it is just the CHECK_CXX_COMPILER_FLAG portion which is not working. Please note that in gcc-4.6, support for c++0x/c++11 is experimental. -- https://code.launchpad.net/~widelands-dev/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cxx11 into lp:widelands

This also fails on Gentoo where gcc-4.6.3 is standard. problem is that at least on my system, the CHECK_CXX_COMPILER_FLAG(${PARAMETER_COMPILERFLAG_CXXSTD} Compiler_std_supported) is not successful, hence -std=c++0x (or -std=c++11) is not added to the compiler flags, and then the compilation fail

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/graphic_resetting into lp:widelands

I also can't make it crash anymore :-) -- https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/graphic_resetting. ___ Mailing list: https:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1098263 into lp:widelands

I moved this branch to ~widelands-dev and will do so in the future :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug1098263/+merge/174275 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug1098263 into lp:widelands. ___

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1098263 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug1098263 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1098263 in widelands: "Widelands does not start if PC has OpenGL problems" https://bugs.lau

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1197429 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug1197429 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1197429 in widelands: "Fail to build in Ubuntu 12.04 LTS" https://bugs.launchpad.net/widelands/+b

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/make_opengl_glew_gettext_mandatory into lp:widelands

sorry I messed up the branches when pushing, now it is the correct proposal :) -- https://code.launchpad.net/~qcumber-some/widelands/make_opengl_glew_gettext_mandatory/+merge/156258 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/make_opengl_

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/make_opengl_glew_gettext_mandatory into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/make_opengl_glew_gettext_mandatory into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1159000 in widelands: "Building WL should check whether gettext is installed&quo

Re: [Widelands-dev] [Merge] lp:~nha/widelands/release-warnings into lp:widelands

Review: Approve Took me a while to find the time, but I think now this is ok. I also think this does not touch MSVC, but I really don't want to set a final OK on that as I don't really know what happens there ;-) So, ok from me (Linux), but it would be great to have some check by an MSVC user.

Re: [Widelands-dev] [Merge] lp:~csirkeee/widelands/bug1150517_2 into lp:widelands

Your change is the absolutely right way if we can say we don't want to use SDL_mixer below 1.2.12 at all. In that case, consider this approved. If you only want to throw a warning (as asked in the request), then your way does prevent users of old SDL_mixer versions from compiling widelands. I c

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug1128114 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug1128114 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1128114 in widelands: "segmentation fault when running with --dedicated" https://bugs.launchpad.net

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug704637_2 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug704637_2 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~qcumber-some/widelands/bug704637_2/+merge/151828 Additional commit regarding

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug704637 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug704637 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #704637 in widelands: "Does not start (could not set video mode) using too large resolution in fullscreen

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug543113 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug543113 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #543113 in widelands: "Land owned statistics should not display number of fields but instead % of total map

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/cppcheck_prefix_plusplus into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/cppcheck_prefix_plusplus into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #986611 in widelands: "Issues reported by cppcheck" https://bugs.launchpad.net/wide

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/cppcheck_const_refs into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/cppcheck_const_refs into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #986611 in widelands: "Issues reported by cppcheck" https://bugs.launchpad.net/widelands/+

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

I did some more coding, and made the system load the files at the beginning, but letting the Main thread render the animations. This revealed (at least for my system) that the slow part of this task is not reading the files from disk, but the rendering task itself. Unfortunately, with the curre

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

It's up to date again. Sorry for the inconvenience... -- https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/animations into lp:widelands. __

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/animations into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138 I'm feeling I should add a r

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

The proposal to merge lp:~qcumber-some/widelands/animations into lp:widelands has been updated. Status: Merged => Work in progress For more details, see: https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138 -- https://code.launchpad.net/~qcumber-some/widelands/animati

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

Sorry this was not merged but I've unfortunately overwriten my branch with trunk. I'm setting this back to Review requested once I recreated the changes. -- https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138 Your team Widelands Developers is requested to review the propo

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

The animations which are loading after creating a map are all animations which are visible, except water animations. For example: Trees, animals, and the visible starting buildings (HQ, road and flag). Nothing else. I'm currently trying to find a way (more theoretically) how to achieve a preload

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

> I tested your branch and I am very impressed by the short loading time it > takes. > If the world animations would be preloaded and only the tribes "on the fly", > it > seems to me to be a very good solution for the loading-animations-time > problem! This would probably not be so easy since the

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/animations into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/animations into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~qcumber-some/widelands/animations/+merge/104138 I'm feeling I should add a r

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bug961548 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bug961548 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #961548 in widelands: "widelands executable links against boost_unit_test_framework in Debug mode&quo

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/minizip into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/minizip into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #536161 in widelands: "Widelands bundles internal copy of unzip.cc" https://bugs.launchpad.net/wide

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widelands

As I said, I propose for inclusion after Build17 :-) -- https://code.launchpad.net/~qcumber-some/widelands/cmake_fail_on_sdl_accessories/+merge/100300 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widel

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #970264 in widelands: "Missing SDL_* libraries lead to rather useless messages&quo

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/bugfix-657404 into lp:widelands

I'm not fit enough to fix this, I tried but I don't understand it at this moment. I'll open another bug for the campaign titles and merge this as it fixes the display problem, while the other problem is map_io internal. -- https://code.launchpad.net/~qcumber-some/widelands/bugfix-657404/+merge/9

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bugfix-657404 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bugfix-657404 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #657404 in widelands: "When loading a savegame, the original map name is shown instead of the translate

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/alocritani-896879-add_replacement_for_remove_replays into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/alocritani-896879-add_replacement_for_remove_replays into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #896879 in widelands: "Patch - Changes to spinboxes' behaviou

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/alocritani-896879-change_button_enable_logic into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/alocritani-896879-change_button_enable_logic into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #896879 in widelands: "Patch - Changes to spinboxes' behaviou

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/alocritani-896879-switch_buttons into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/alocritani-896879-switch_buttons into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #896879 in widelands: "Patch - Changes to spinboxes' behaviour" https://bug

Re: [Widelands-dev] [Merge] lp:~tino79/widelands/gettext018 into lp:widelands

> Ergh, let me guess, this is not only a problem where _MSC_VER ist defined... Well, my gettext: $ gettext -V gettext (GNU gettext-runtime) 0.18.1 Copyright © 1995-1997, 2000-2007 Free Software Foundation, Inc. Lizenz GPLv3: GNU GPL Version 3 oder später Dies i

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/bugfix-768854 into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/bugfix-768854 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #768854 in widelands: "Messages for win condition "Territorial Lord" is not translat

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/svn-treatment into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/svn-treatment into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: #536604 Messy hiding of directories https://bugs.launchpad.net/bugs/536604 Removed all occurencies of special

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/lumberjack-vision into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/lumberjack-vision into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: #585107 Lumberjack ignores player's vision range https://bugs.launchpad.net/bugs/585107 worker co

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fixbug-669380 into lp:widelands

Review: Approve -- https://code.launchpad.net/~widelands-dev/widelands/fixbug-669380/+merge/39737 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fixbug-669380. ___ Mailing list: https://launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fixbug-669380 into lp:widelands

looks quite good, shouldn't harm on Linux and Mac shouldn't harm Linux -> Windows MinGW crosscompiling either -- https://code.launchpad.net/~widelands-dev/widelands/fixbug-669380/+merge/39737 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fixbug-669380. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fixbug-669380 into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/fixbug-669380 into lp:widelands has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~widelands-dev/widelands/fixbug-669380/+merge/39737 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wid

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands

The proposal to merge lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands has been updated. Status: Approved => Merged -- https://code.launchpad.net/~qcumber-some/widelands/spice-up-cmake/+merge/39723 Your team Widelands Developers is requested to review the proposed merge of lp:~qc

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands

The proposal to merge lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~qcumber-some/widelands/spice-up-cmake/+merge/39723 Your team Widelands Developers is requested to review the proposed merge of

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/spice-up-cmake into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: #551716 CMake should offer a switch to disable GGZ support even if GGZ is found https://bugs.launchpad.net/bugs

[Widelands-dev] [Merge] lp:~qcumber-some/widelands/fix-locale-on-linux into lp:widelands

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/fix-locale-on-linux into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: #563285 Locales are not found if selected, and LANG states non-default (subcategory) name https