[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1741778-statistics_window_leaks into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/bug-1741778-statistics_window_leaks into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1741778 in widelands: "Plot area of Statistics has memory leak" https://bugs.lau

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands has been updated. Commit Message changed to: Fix heap use after free bug, and avoid immovables to end up wrong positions when pressing undo/redo in editor For more details, see:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands has been updated. Commit Message changed to: Fix bug 1735980 related problems For more details, see:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/fix-bug-1735980-related-problems into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1735980 in widelands: "use-after-free in editor" https://bugs.launchpad.net/widelands/+b

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1699778-multilineeditbox-handle-key-enter into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/bug-1699778-multilineeditbox-handle-key-enter into lp:widelands has been updated. Description changed to: The change in the branch fixes the bug 1699778. update() function sets the ww_valid flag off which means that multilineeditbox must be

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1699778-multilineeditbox-handle-key-enter into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/bug-1699778-multilineeditbox-handle-key-enter into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1699778 in widelands: "Multilineeditbox: Advance cursor to the next line when

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/multilineeditbox-uninitialized_value into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/multilineeditbox-uninitialized_value into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/multilineeditbox-uninitialized_value

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into lp:widelands

Ok, I change the value! -- https://code.launchpad.net/~widelands-dev/widelands/enemysites_check_delay_used_before_initialized/+merge/334287 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/enemysites_check_delay_used_before_initialized into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1734544 in widelands: "Member variable DefaultAI::enemysites_check_delay_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scenario_types_used_before_initialized into lp:widelands

Of course I can! In that way it is even more readable. Thanks! -- https://code.launchpad.net/~widelands-dev/widelands/scenario_types_used_before_initialized/+merge/334285 Your team Widelands Developers is requested to review the proposed merge of

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/scenario_types_used_before_initialized into lp:widelands

Jukka Pakarinen has proposed merging lp:~widelands-dev/widelands/scenario_types_used_before_initialized into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/scenario_types_used_before_initialized

[Widelands-dev] [Merge] lp:~flegu/widelands/fix_some_memory_leaks into lp:widelands

Jukka Pakarinen has proposed merging lp:~flegu/widelands/fix_some_memory_leaks into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~flegu/widelands/fix_some_memory_leaks/+merge/333930 There happens memory leaks detected

Re: [Widelands-dev] [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

> Thanks for the fix! > > Looks good to me - can you please replace UI::RenderedText::Shared with > std::shared_ptr and get rid of the new using statement? I > think that would make the code easier to read. Sure, I can do that. --

[Widelands-dev] [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

Jukka Pakarinen has proposed merging lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~flegu/widelands/r8481-renderedtext-memory-leaks/+merge/333578 Valgrind

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/savegame-menu into lp:widelands

I have been testing the branch and today got it crash. This is how it crashes: Single Player New Game Click Crater and then OK Start game Main Menu Save Game Write some Filename and then OK Main Menu Exit Game OK Watch Replay Choose the saved game and then OK Wait until the end of replay and