> I do not feel like going over this and clean it up. I do not understand most
> of the intentions.
>
> Martin, are you still interested to work on this? Otherwise I will drop this
> branch in a few days.
You can delete this branch, I had too much trouble with it.
--
https://code.launchpad.net
ok, thanks, I will look into this
--
https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/find_attack_soldiers.
___
Mailing list: https
I will create a bug report as soon as this branch is merged.
--
https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/find_attack_soldiers.
I guess it is ready to merge.
What is implemented:
- defend with "strongest", attack with "strongest"
- drop "weakest", but only unwounded soldiers (because wounded soldiers will
heal)
I am quite happy with how it works and feels playing with this branch.
What is missing:
- the list of soldier
What is the best way to proceed for establishing the invariant that soldiers in
the military building have to be sorted:
- create a bug report / wishlist,
- create a blue print or
- start coding and propose a merge request ?
--
https://code.launchpad.net/~widelands-dev/widelands/find_attack_sold
Your patch was really useful, I just changed the sorting to stl and that's it.
I also tried a short game and it really makes a difference seeing soldiers
coming from all military builings in range to attack instead of weaking one
building totally.
Here is the patch:
=== modified file 'src/logi
Martin Schmidt has proposed merging
lp:~widelands-dev/widelands/observer_building_spaces_codecheck_errors into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands
Can I just push to this branch or should I use a new one?
I did not change the semnatics but rather replace the sorting by
stable_sort or partial_sort (which returns the k smallest elements but is
unstable)
However, I am not sure whether an unstable sorting algorithm can cause
desyncts, since t
Martin Schmidt has proposed merging
lp:~widelands-dev/widelands/observer_building_spaces into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/observer_building_spaces/+merge/249764
move of toogle
Martin Schmidt has proposed merging
lp:~martinschmidt/widelands/observer_building_spaces into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1419537 in widelands: "Allow Observers to show building spaces"
https://bugs.launchpad.net/wide
Martin Schmidt has proposed merging lp:~martinschmidt/widelands/bug1420521 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1420521 in widelands: "Reset target quantitiy is overwritten easily"
https://bugs.launchpad.net/widelands/+b
11 matches
Mail list logo