[Widelands-dev] [Merge] lp:~widelands-dev/widelands/get_defeated_fix into lp:widelands

2013-07-12 Thread cghislai
cghislai has proposed merging lp:~widelands-dev/widelands/get_defeated_fix into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1198624 in widelands: "A player should be considered defeated in Autocrat after losing all warehouses, rather than all buil

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/get_defeated_fix into lp:widelands

2013-07-13 Thread SirVer
Review: Abstain I think the bug needs a bit more discussing, I am not convinced that this is needed or even a good idea - see my comments on it. -- https://code.launchpad.net/~widelands-dev/widelands/get_defeated_fix/+merge/174470 Your team Widelands Developers is subscribed to branch lp:~widel