The proposal to merge lp:~widelands-dev/widelands/oars_appdata into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624
--
Your team Widelands Developers is subscribed to branch
Thanks - that error message was confusing me!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309624
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/oars_appdata.
___
Mailin
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into
lp:widelands has been updated.
Commit Message changed to:
Added age ratings to Appdata https://odrs.gnome.org/oars and validator call to
utils/uppdate_appdata.py. Fixed localization format for long description. Fixed
id tag.
Review: Needs Fixing
One more things:
The specification you mentioned is for the *.desktop files not *.appdata.xml
files. The appdata specification does not mention the type property so I think
we can trust the validator and remove it.
--
https://code.launchpad.net/~widelands-dev/widelands/oa
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into
lp:widelands has been updated.
Commit Message changed to:
Added age ratings to Appdata https://odrs.gnome.org/oars and validator call to
utils/uppdate_appdata.py. Fixed localization format for long description.
For more detail
Review: Resubmit
Thanks for the review - could you please check again for me?
I have added the validator to utils/uppdate_appdata.py now, so I can't forget
to validate again.
It's now throwing a warning "Found invalid tag: 'content_rating'", but I guess
that's because the format is new and the
Review: Needs Fixing
LBTM. This is invalid XML, you have multiple root tags. The
has to be a child of .
You can use the appstream package of your distribution to validate appstream
files. E.g:
appstreamcli validate debian/widelands.appdata.xml
It throws a lot of errors, even before your chan
GunChleoc has proposed merging lp:~widelands-dev/widelands/oars_appdata into
lp:widelands.
Commit message:
Added age ratings to Appdata https://odrs.gnome.org/oars
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/wideland
You're right. I can't change the target, so I'll delete this proposal and
create a new one.
--
https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/oars_appdata into
Continuous integration builds have changed state:
Travis build 1529. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/171459465.
Appveyor build 1371. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_oars_appda
The diff shows much more changes than the appdata... i guess this is not the
one that should go into build19?
--
https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wideland
11 matches
Mail list logo
