cghislai has proposed merging
lp:~widelands-dev/widelands/save_dialog_improvements into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #706284 in widelands: "Default save file name is always the first in list"
https://bugs.launchpad.net/widelands/+bu
The proposal to merge lp:~widelands-dev/widelands/save_dialog_improvements into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
--
https://code.launchpad.net/~wide
Review: Needs Fixing
I did a review in r6620. There is some code duplication which should be
factored into a method and a bunch of comments. As before just grep() for
#cghislai to find all comments or look at the diff.
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improveme
Should be ready if not bad design decision have been made
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/save_dialog_improvements.
___
I had one more issue and proposed a fix for it in my latest revision. Can you
have a quick look and say if it is fine?
lgtm otherwise - I will merge as soon as I hear back from you.
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands
Review: Approve
Yep looks good to me.
And sorry for the braquets includes, i will double check next commits
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/save_dialog
Thanks and np! I enjoy your contributions very much :)
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/save_dialog_improvements.
__
7 matches
Mail list logo
