[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 -- Your team Widelands Developers is su

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 5389. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/581267547. Appveyor build 5159. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_co

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread hessenfarmer
Hm I still get the following error in a release build. Unexpected error during the game vector::_M_range_check: __n (which is 255) >= this->size() (which is 131) will install a debug build now -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team W

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
Review: Approve @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/amazons-coding-changes. ___ Mailing list: ht

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
Review: Approve Looks like the crash has been identified: https://www.widelands.org/forum/topic/2897/?page=11#post-29630 So, this is a data issue unrelated to this branch. I'll revert the tribes and merge. -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands has been updated. Commit message changed to: Implements the coding changes required for the new amazons tribe: - findspace:swim (for water gatherers) - Enhancing terrains (for gardening center) - Construct

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-05 Thread TiborB
try with gdb if you can -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/amazons-coding-changes. ___ Mailing list: https:/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-04 Thread hessenfarmer
While running an Ai only local multiplayer with 4 amazon tribes I get a crash with not very much information logged. Currently I don't know where this is coming from. -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is sub

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-04 Thread bunnybot
Continuous integration builds have changed state: Travis build 5386. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/580710729. Appveyor build 5156. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_co

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-04 Thread hessenfarmer
Review: Approve test tested all the features of this branch with my data branch. if this is good to go code wise we should think about a merge strategy. I believe we can let this go in. as it doesn't change the game and then concentrate on the data and graphics. Otherwise we can merge this into

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-03 Thread bunnybot
Continuous integration builds have changed state: Travis build 5383. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/580196177. Appveyor build 5153. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_cod

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-03 Thread Benedikt Straub
Fixed the fieldaction bug and split off FindNodeTerraform. New terraform syntax: "findspace=size:any radius:6 terraform", "walk=coords", "terraform", "return" There´s no real reason why we need a World or EGBase in Tool parameters, is there? I removed it, as it can be fetched directly from th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-30 Thread hessenfarmer
Review: Needs Fixing playtest I confirmed the critical behaviour (not having the build menu with buildcaps already have a flg build) is not in trunk so this needs fixing -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-28 Thread hessenfarmer
I just tested it with my first loadable(playable?) amazons data dir. However I didn't get a building menu when clicking on buildcap that already had a flg built. I got a view only menu instead. -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-28 Thread GunChleoc
I have done a first round of code review, no testing yet. Diff comments: > > === modified file 'src/editor/tools/delete_critter_tool.cc' > --- src/editor/tools/delete_critter_tool.cc 2019-02-23 11:00:49 + > +++ src/editor/tools/delete_critter_tool.cc 2019-08-23 14:48:43 + > @@ -41,7

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-23 Thread bunnybot
Continuous integration builds have changed state: Travis build 5337. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/575756820. Appveyor build 5108. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-23 Thread Benedikt Straub
For more information about the concepts, see the discussion at https://www.widelands.org/forum/post/29315/ onwards… -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is requested to review the proposed merge of lp:~wideland

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-23 Thread Benedikt Straub
The barbarian sites modified in this branch are only testcases, not intended for merging. The new amazons tribe (under development in another branch) will have a "Gardening Center" whose only purpose is that the worker walks around and turns the terrain nearby into a different, more fertile ter

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-23 Thread TiborB
"treetop" means - in the branches of the mature tree, or does the building replace a tree? -- https://code.launchpad.net/~widelands-dev/widelands/amazons-coding-changes/+merge/371725 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/amazons-c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-08-23 Thread TiborB
So some sites (barbarian well and forester) will also "upgrade" land types as a side effect of cutting wood or mining water? Anyway this does not seem dangerous to me. What I dont understand is capability to build a sentry over a tree. Did you create another buildable field type, because this ca