The proposal to merge lp:~widelands-dev/widelands/bad_cast into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bad_cast/+merge/313283
--
Your team Widelands Developers is subscribed to branch
lp:~wide
Thanks for the review! Addressed all comments, gonna merge this now as the bug
is critical.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bad_cast/+merge/313283
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bad_cast.
_
Review: Approve
I tested it, I failed to get a crash so perhaps it is OK now :)
--
https://code.launchpad.net/~widelands-dev/widelands/bad_cast/+merge/313283
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bad_cast.
Review: Approve
Code LGTM, not tested. Some tiny nits.
Diff comments:
>
> === modified file 'src/logic/map_objects/immovable.h'
> --- src/logic/map_objects/immovable.h 2016-11-22 19:11:01 +
> +++ src/logic/map_objects/immovable.h 2016-12-14 22:13:01 +
> @@ -202,9 +202,10 @@
> MO_D
Continuous integration builds have changed state:
Travis build 1768. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/184092656.
Appveyor build 1606. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bad_cast-1
SirVer has proposed merging lp:~widelands-dev/widelands/bad_cast into
lp:widelands.
Commit message:
Avoid accessing invalid memory by copying needed data to the stack.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1648178 in widelands: "Fatal Exception: Bad Cast"
also some tiny renames to make the code a bit easier to understand.
--
https://code.launchpad.net/~widelands-dev/widelands/bad_cast/+merge/313283
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bad_cast into lp:widelands.
__
7 matches
Mail list logo
