Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1074353.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
I found a couple of minor bugs and made the testsuite pass again. Great that
you wrote tests for all your methods! It made it really easy to find,
understand and fix bugs.
I merged this now. This is a great contribution and a big chunk of work! Thanks
for your persistence with this :). It great
The proposal to merge lp:~widelands-dev/widelands/bug-1074353 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
--
https://code.launchpad.net/~widelands-dev/widelands/bug-10
I adressed the remaining comments in 6926.
One question was how to get a object from c++ to Lua. There is a template
function to_lua<> for this. Usage is like this:
to_lua(L, new
L_WareDescription(tribe.get_ware_descr(ware_amount.first)));
This generates a L_WareDescription and pushes it at t
The proposal to merge lp:~widelands-dev/widelands/bug-1074353 into lp:widelands
has been updated.
Description changed to:
This is in a mergeable state now, although more work needs to be done, as
commented in the source code (comments are in lua_map.cc and format_help.lua).
The remaining issue
The last 2 commits are NOCOM(#sirver) comments that need attention.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1074353.
___
Mai
I have started on the NOCOMs.I have added the 3 persist/unpersist objects to
the test suite (lua_persistence.wmf), but when I run it, it complains about a
missing init.lua:
bratzbert@museum:~/sources/widelands/bug-1074353$ ./widelands
--scenario=test/maps/lua_persistence.wmf
Set home directory:
Review: Needs Fixing
Okay, done reviewing. I think this is nearly ready. I added a bunch of NOCOM,
let me know if you need help with any of them.
I see a bunch of followup tasks that result from this branch. I outline them
here, but they do not need to be done in this branch. If you do not want
I think in the code is better, because we would end up with a very big screen
full of stuff.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1074353 into l
This is a lot to review and I think I will have a bunch of comments. Should I
do it here or rather in the code?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
10 matches
Mail list logo
