The proposal to merge lp:~widelands-dev/widelands/bug-1174075 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
--
https://code.launchpad.net/~widelands-dev/widelands/bug-11
Review: Approve
one nit. Please fix and merge.
Diff comments:
> === modified file
> 'src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc'
> --- src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc
> 2014-09-10 14:08:25 +
> +++ src/editor/ui_menus/editor_tool_set_terrai
Review: Resubmit
> re arable - better than green, but very rare and most non-native speakers will
> not understand this, I think. But I am not against it... :)
They can translate the game into their language then :P
I have now found a good use for the vector - I made everything lowercase as
Tib
re arable - better than green, but very rare and most non-native speakers will
not understand this, I think. But I am not against it... :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wid
I think the word we're looking for here is "arable". Will go change :)
I am not happy with the switched to vecrot proposed in the diff comments, could
I please have feedback on that before we merge this?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team W
maybe we just can agree that 'green' should be replaced by 'buildings allowed'
(or anything in this sense) in the tooltips and merge this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team Widelands Developers is subscribed to branch
lp:~widelands
I remember that I reverse engineered the types of terrain that settlers 2 would
use. I then picked keywords that seemed reasonable to me back then, they are
terrible of course from what we see today.
green only means that buildings and trees and stuff can grow there. Similar to
the others: they
I just found that in world/terrains/init.lua terrain types are defined with "is
=" as green, including those that definitelly are not 'green'. Maybe the
keyword was improperly picked?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team Widelands Developers
> > > Are you using "green" to indicate "buildings allowed"?
> >
> > I don't know what it's used for.
>
> It seems to me that it belongs to "house" icon, anyway it is confusing for
> user
Can somebody who actually knows that this is for give us a hint?
> > Yes, it's one of the original terrain
> > Are you using "green" to indicate "buildings allowed"?
>
> I don't know what it's used for.
It seems to me that it belongs to "house" icon, anyway it is confusing for user
> Yes, it's one of the original terrain types. These match the descnames you see
> on the bottom when you click on an e
Another question regarding the switch to vector
Diff comments:
> === modified file
> 'src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc'
> --- src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc
> 2014-09-10 14:08:25 +
> +++ src/editor/ui_menus/editor_tool_set_terrai
> Are you using "green" to indicate "buildings allowed"?
I don't know what it's used for.
> F.e. 'Water (Desert): Water Unpassable Trees'
> what about this layout:
> Water (Desert): water, unpassable, trees
I'm actually not sure if native speakers would prefer title case here or not.
> Is 'De
Question for one of the nits - see diff comment.
Diff comments:
> === modified file
> 'src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc'
> --- src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc
> 2014-09-10 14:08:25 +
> +++ src/editor/ui_menus/editor_tool_set_terra
Review: Needs Fixing
Diff comments:
> === modified file
> 'src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc'
> --- src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc
> 2014-09-10 14:08:25 +
> +++ src/editor/ui_menus/editor_tool_set_terrain_options_menu.cc
Are you using "green" to indicate "buildings allowed"?
F.e. 'Water (Desert): Water Unpassable Trees'
what about this layout:
Water (Desert): water, unpassable, trees
Is 'Desert' in above example needed, what information it gives? Is it original
terrain type (one of 4 worlds) ? Why it is not show
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1174075 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1174075 in widelands: "Clarify meaning of icons in editor terrain
preview"
https://bugs.launchpad.net/widelands/+bug/1174075
16 matches
Mail list logo
