Review: Approve
not as much simplified as I hoped through pushd/popd, but I think it still is
better. Ship it!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1219914.
I did run it with sh explicitly, because otherwise I got a permission denied
error. After the chmod, it is now working.
Do you still want me to change from cd to pushd?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed
OK, next try.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1219914.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
I replaced 'ls | grep' with '-f' and optimized a bit.
pushd is still an unknown command. If I try this:
#!/bin/bash
pushd /etc
I get:
merge_and_push_translations.sh: 3: merge_and_push_translations.sh: pushd:
not found
--
ls -la /bin/bash
What is it pointing to? Sounds like it might be symlinked to sh or something.
pushd and popd are some of the specific features which are only found i bash,
not a standard POSIX-shell. (Probably why SirVer told you to specify bash
insted of sh in the first line of the file.
Review: Approve
pushd is still an unknown command.
How do you run the script? If you mark it executable (chmod 755 script.sh) and
run it as ./utils/script.sh it should work.
But it is fine to merge this as is I'd say.
--
My terminal doesn't seem to know pushd/popd, so I have added some tests with ls
| grep.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1219914.
Review: Needs Fixing
Diff comments:
=== added file 'utils/merge_and_push_translations.sh'
--- utils/merge_and_push_translations.sh 1970-01-01 00:00:00 +
+++ utils/merge_and_push_translations.sh 2014-12-01 09:36:12 +
@@ -0,0 +1,61 @@
+## This script will fix translations
http://www.peterbe.com/plog/set-ex
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1219914/+merge/242772
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1219914.
___
Mailing list:
the fix to the translations branch on Launchpad.
- Afterwards, the translations branch will be merged into trunk,
the catalogs be updated and the result pushed to trunk on Launchpad.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug
10 matches
Mail list logo
