[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-18 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 -- https://code.launchpad.net/~widelands-dev/widelands/bu

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-15 Thread GunChleoc
Done. I also added an exception to the CamelCase codecheck rule to avoid the false positives. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1343297_2.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-14 Thread SirVer
Convert those to using too, but keep the names (that is a compatibility fix for windows). -- https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1343297_2.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-14 Thread SirVer
Review: Needs Fixing -- https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1343297_2. ___ Mailing list: https://launchpad.net/~widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-14 Thread GunChleoc
Review: Resubmit All done. Codecheck still coughs up 2 tyxpedefs in src/network/network_system.h, but I don't know what to do about those. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-13 Thread GunChleoc
Sounds good to me: I'll switch everything to "using", which will make for an easier code check rule afterwards -- https://code.launchpad.net/~widelands-dev/widelands/bug-1343297_2/+merge/234183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1343297_2. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-13 Thread SirVer
> what does the _t in TypeAndLevel_t mean? We also have some _s stuff in the > typedefs. The _t mymics standard naming conventions from C++: uint8_t (_t stands for type). I think it unwise to use this for user defined types as for me it symbolizes a standard type. _s I have no idea what it shou

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1343297_2 into lp:widelands

2014-09-11 Thread GunChleoc
2 questions then: what does the _t in TypeAndLevel_t mean? We also have some _s stuff in the typedefs. I also have trouble with a rule for everything - a simple check for underscore won't do, because of the uint16_t in definitions like std::pair. Also, some typedefs are multiline with brackets.