The proposal to merge lp:~widelands-dev/widelands/bug-1371062 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1371062.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Review: Resubmit
OK, done. I think.
The confirmation box now also kills the Game Options Menu. If that isn't wanted
behaviour, I can easily change that - it's just 1 line of code to remove.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Deve
+1 :). I thought that the message boxes had this behaviour already (build in),
but it seems like they are no unique windows, so this will not work out the way
I hoped. So let's accept that there will be multiple dialogues possible.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-13710
I tried that as well, but I can't avoid having multiple windows being
generated, which is behaviour you pointed out that we don't want. So, not
making it unique implies the current behaviour. So, I need a +1 on that before
I change the code again.
--
https://code.launchpad.net/~widelands-dev/wi
Or just do not bother with making the dialogue unique in the first place. As
mentioned, all dialogues seem to be non unique in Widelands right now. If we
change that, we should change it for all dialogues at the same time.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+mer
oops, it is there. I was looking on wrong branch...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1371062.
___
Mailing list: https
What about confirmation dialog when exiting Multiplayer (LAN/Direct IP) game?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1371062.
_
OK, after a couple of hours of fiddling and trying all kinds of things from
disabling the Exit button to using a unique_ptr, I am left with the following
options:
- Try to understand the whole ActionWindow control flow (tried before and
failed, but a second look can never hurt)
- Implement a U
Review: Needs Fixing
Code looks good (I fixed some nits around, nothing major). the friend
declaration was not necessary, so I removed it.
it doesn't quite work on my system:
- exit shows the dialogue, ctrl exit quits immediately. this is working as
intended.
- the dialogues buttons also do the
I dont dare to review the code, but at least I can confirm it works :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1371062/+merge/238048
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1371062 into lp:widelands.
_
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1371062 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1371062 in widelands: "Add confirmation dialog to exit game"
https://bugs.launchpad.net/widelands/+bug/1371062
For more detai
12 matches
Mail list logo
