[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands

2016-04-23 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1542821-internet-exceptions/+merge/292698 -- Your t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands

2016-04-23 Thread GunChleoc
The internet code is complicated, and I have never analysed the complete workflow. I just searched for "catch" and found the spot. The idea with the version came from IRC ;) +Thanks for the review! @bunnybot merge --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands

2016-04-23 Thread Klaus Halfmann
Review: Approve compiled, tested, code review That was easy, I still do not find my way around in that Internet code. Thx for fixing this one. Showing the version was _very_ good idea, too -- https://code.launchpad.net/~widelands-dev/widelands/bug-1542821-internet-exceptions/+merge/292698 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands

2016-04-23 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1542821-internet-exceptions into lp:widelands. Commit message: Server and client will now log out when they crash. Requested reviews: Klaus Halfmann (klaus-halfmann) Related bugs: Bug #1542821 in widelands: "Inconsistency after