*with a debug build, sorry.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport.
That bug is really fun but the streamreader isn't to blame. ;-)
The problem is that the float_32() call not only returns the value but also
modifies the internal state of the stream. As a consequence, the order of
assignment to x and y matters (or more precisely, the order in which the
The proposal to merge
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
--
Your t
> That code should be semantically identical?
That's what I thought too when I broke it. I really don't want to dig into the
streamreader right now though - there is some subtle unexpected side-effect
going on there.
@bunnybot merge
--
Now I am confused. That code should be semantically identical?
As peformance optimizer I see the the extra null-assignement is a waste :-)
Can you add a comment what compiler/enviroment causes this problem?
I tested this in bzr8791[trunk] and it was ok for me.
--
Review: Approve
Code is looking good and working as intended.
That definitely is one nasty bug...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
Your team Widelands Developers is subscribed to branch
/_widelands_dev_widelands_bug_1784122_singleplayer_viewport-3618.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1784122-singleplayer-viewport/+merge/353391
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport into lp:widelands
e proposed merge of
lp:~widelands-dev/widelands/bug-1784122-singleplayer-viewport into lp:widelands.
=== modified file 'src/game_io/game_interactive_player_packet.cc'
--- src/game_io/game_interactive_player_packet.cc 2018-07-08 15:16:16 +
+++ src/game_io/game_interactive_player_packet.cc 2018-08-2
8 matches
Mail list logo
