The proposal to merge lp:~widelands-dev/widelands/bug-1805325-joining-lan-games
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
--
Your team Widela
This fixes a crash, so let's have it.
Clang install failure on Travis
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 4433. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/490911106.
Appveyor build 4221. State: success. Details:
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 4433. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/490911106.
--
Tested and working
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games.
Merged trunk so that we can do some testing
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games.
I'd like to have some basic testing done.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games.
I can do so, but this branch haven't been tested by a reviewer yet. Do you want
me to merge this anyway?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
Notabilis, can you merge trunk (if needed) and cause bunnybot to merge? Thanks
:-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games.
Review: Approve code
Code LGTM, no tested yet. 1 small nit for a comment.
Diff comments:
> === modified file 'src/network/gamehost.cc'
> --- src/network/gamehost.cc 2018-11-06 17:05:10 +
> +++ src/network/gamehost.cc 2018-11-28 22:54:33 +
> @@ -1939,6 +1949,8 @@
> Client peer;
/_widelands_dev_widelands_bug_1805325_joining_lan_games-4099.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1805325-joining-lan-games/+merge/359789
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1805325-joining-lan-games into lp:widelands
11 matches
Mail list logo
