The proposal to merge
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
--
Your t
We decided in the bug to merge this, since it doesn't do any harm
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
Your team Widelands Developers is subscribed to branch
I quick game for some 40 minutes, found nothing,
will try to produce this in some coop game perhaps.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
Your team Widelands Developers is subscribed to branch
Review: Needs Information
OK, his is te code that will (new in R20) add the Helpbutton
so the correct helpwindow for the building in progress will be shown.
_parent is the same as igbase() which is used at the very start of the function,
so I have no idea how this should be come null?
Teh
/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev
heap-use-after-free/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
lse will have more creative ideas.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widela
/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev
/_widelands_dev_widelands_bug_1807156_heap_use_after_free-4304.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1807156-heap-use-after-free/+merge/363584
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands
reproduce the original bug, so this fix is just my best guess.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1807156-heap-use-after-free into lp:widelands.
=== modified file 'src/wui/buildingwindow.cc'
--- src/wui/buildingwindow.cc 2019-0
10 matches
Mail list logo
