Notabilis has proposed merging
lp:~widelands-dev/widelands/bug-1808169-disable-focus into lp:widelands.
Commit message:
Allowing hotkey usage while windows are open.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1808169 in widelands: "scrolling not possible with
Continuous integration builds have changed state:
Travis build 4347. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/469721440.
Appveyor build 4141. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1808169
Continuous integration builds have changed state:
Travis build 4365. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/472186290.
Appveyor build 4158. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18081
Continuous integration builds have changed state:
Travis build 4404. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/479143097.
Appveyor build 4195. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_180816
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 4404. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/479143097.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-focus/+merge/361097
Your
The proposal to merge lp:~widelands-dev/widelands/bug-1808169-disable-focus
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-focus/+merge/361097
--
Your team Widelands Developers
I don't see a problem with how things are now. We will need to reconsider this
though if we want to implement full keyboard navigation, e.g. tab through
checkboxes and activate/deactivate them by hitting the space bar.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-fo
Review: Approve played
Can this be merged? I tested this and found no issues.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-focus/+merge/361097
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1808169-disable-focus.
Let's have it. We can always revisit it whenever we get around to implementing
more keyboard navigation.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-focus/+merge/361097
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widela
Again a Travis hiccup.
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1808169-disable-focus/+merge/361097
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1808169-disable-focus.
_
10 matches
Mail list logo