The proposal to merge lp:~widelands-dev/widelands/bug-566729 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
--
https://code.launchpad.net/~widelands-dev/widelands/bug-5667
Review: Approve
I added a bunch of small comments in the last revision (grep for NOCOM). Looks
good to me in general, feel free to merge after you've addressed these.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
Your team Widelands Developers is subscribed to b
Review: Resubmit
A solution has presented itself while I was working on the ui_fsmenu overhaul.
Can I get an approve on this please?
- I removed the localization from the WUI save game window, because it's
probably confusing not to work on the direct filenames anyway. Since we now
have a prope
No worries, the code isn't going anywhere ;)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-566729.
___
Mailing list: https://launch
I need to look into this a bit more closely, maybe I can suggest a better place
then. I'll be busy for another week, then I should be back to my old productive
self :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
Your team Widelands Developers is subscribed to
I'm not sure where to put Game_Preload_Data_Packet::get_localized_display_title
The only common included header that would marginally make sense is
logic/game_controller.h. Or a new h/cpp for this?
base/time_string.h doesn't make sense either, because we would have a reference
to game_controller
Review: Needs Fixing
I found the bug - you set the variables in the section after the "preload" file
was already written. I also added a bunch of comments to the code, but I think
you can take it up again from here.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
I have now added data to game_preload_data_packet, but it is always empty and I
have no idea why.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-566729.
__
I will try doing the redesign for the metadata. At the moment, if the filename
doesn't conform to the datetime format, the filename is shown as is.
At to blitting the gametime to the editor, it will count from 0, just like in
the game. No harm done, or does this need to go?
--
https://code.laun
Review: Needs Fixing
Relying on the filenames is a no go - we have no control over these. Instead,
we need to save the metadata that is encoded in the filenames into the game
somehow and use it for parsing.
Diff comments:
> === modified file 'src/base/time_string.cc'
> --- src/base/time_string
Now fully localized filenames for replays. Ready for merging now.
Please update the .pot catalogs after merging.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-566729/+merge/229302
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-566729 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #566729 in widelands: "Add gametime display to replays"
https://bugs.launchpad.net/widelands/+bug/566729
For more details, see:
12 matches
Mail list logo
