The proposal to merge
lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building.
Review: Approve
lgtm. minor nits inlined.
Diff comments:
>
> === modified file 'src/logic/map_objects/immovable.cc'
> --- src/logic/map_objects/immovable.cc2016-11-03 07:37:58 +
> +++ src/logic/map_objects/immovable.cc2016-11-17 08:29:59 +
> @@ -340,8 +344,9 @@
>
Continuous integration builds have changed state:
Travis build 1619. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/176633949.
Appveyor build 1457. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
('The read operation timed out',)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 1619. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/176633949.
Appveyor build 1457. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
HTTP Error 500: Internal Server Error
--
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818
Your team Widelands Developers is subscribed to branch
Review: Resubmit
Next try.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-863185-census-on-destroyed-building/+merge/309818
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-863185-census-on-destroyed-building.
Review: Needs Fixing
Diff comments:
> === modified file 'src/logic/map_objects/immovable.cc'
> --- src/logic/map_objects/immovable.cc2016-11-03 07:20:57 +
> +++ src/logic/map_objects/immovable.cc2016-11-03 07:36:43 +
> @@ -339,6 +339,7 @@
>
>
9 matches
Mail list logo