The proposal to merge
lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference/+merge/326257
--
Y
The proposal to merge
lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference into
lp:widelands has been updated.
Commit Message changed to:
Pass function arguments per const reference where possible.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference/+merge/326257
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference.
___
Continuous integration builds have changed state:
Travis build 2360. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/246575895.
Appveyor build 2188. State: success. Details:
Thanks for the review - I have reverted those changes.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference/+merge/326257
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference.
Review: Needs Fixing
Diff comments:
>
> === modified file 'src/graphic/text/rt_render.cc'
> --- src/graphic/text/rt_render.cc 2017-06-01 08:52:15 +
> +++ src/graphic/text/rt_render.cc 2017-06-24 11:37:18 +
> @@ -969,7 +969,7 @@
> public:
> TagHandler(Tag& tag,
>
(argument -> (const) argument&)
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-986611-cppcheck-pass-by-reference into
lp:widelands.
=== modified file 'src/base/i18n.cc'
--- src/base/i18n.cc 2017-01-25 18:55:59 +
+++ src/bas
7 matches
Mail list logo
