The proposal to merge
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+me
Review: Approve
lgtm.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+merge/326256
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables.
Review: Resubmit
I have now gone through the code base and removed all empty string
initializations. I also found a few more uninitialized variables in
MapTriangleRegion.
If you agree with these changes, the branch will be ready.
--
The proposal to merge
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into
lp:widelands has been updated.
Commit Message changed to:
Initialize a bunch of uninitialized member variables, adding constructors where
necessary. Turned some enums into enum classes. Removed
I am currently running the report, which will probably take all day. I'll then
run it again without the string init to see if it makes a difference.
I'll then revert any changes in this branch that won't fix the report.
--
> Well, it's just the same as initializing numbers to 0 - cppcheck is
> complaining, so I'm trying to get rid of that noise in the report.
That would be wrong though - plain old datatypes (POD) are not initialized in
cpp, so numbers are indeed a random value if not properly initialized.
Well, it's just the same as initializing numbers to 0 - cppcheck is
complaining, so I'm trying to get rid of that noise in the report.
The actual error message is:
src/game_io/game_preload_packet.h:38: (style) The struct 'GamePreloadPacket'
does not have a constructor although it has private
Review: Approve
3 nits about initializing std::string = "", otherwise lgtm. I think this can go
in once you have a look at the nits.
Diff comments:
>
> === modified file 'src/game_io/game_preload_packet.h'
> --- src/game_io/game_preload_packet.h 2017-01-25 18:55:59 +
> +++
Continuous integration builds have changed state:
Travis build 2518. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/262995097.
Appveyor build 2342. State: success. Details:
Continuous integration builds have changed state:
Travis build 2517. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/262810177.
Appveyor build 2341. State: success. Details:
Review: Resubmit
Ready for the next round.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+merge/326256
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables.
Continuous integration builds have changed state:
Travis build 2391. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/247860909.
Appveyor build 2219. State: success. Details:
Review: Needs Fixing
Diff comments:
>
> === modified file 'src/base/md5.h'
> --- src/base/md5.h2017-01-25 18:55:59 +
> +++ src/base/md5.h2017-06-28 08:25:35 +
> @@ -74,7 +74,7 @@
> */
> template class MD5Checksum : public Base {
> public:
> - MD5Checksum() {
> +
to review the proposed merge of
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into
lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https
cm.time = time(nullptr);
> + cm.playern = Widelands::neutral();
Maybe create a constructor for chat messages which only takes a message?
> cm.msg = msg;
> messages.push_back(cm);
>
--
https://code.launchp
/_widelands_dev_widelands_bug_986611_cppcheck_uninitialized_variables-2219.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+merge/326256
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized
/_widelands_dev_widelands_bug_986611_cppcheck_uninitialized_variables-2184.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables/+merge/326256
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized
26256
I'm on a code cleanup rampage today... this one needs a bit of looking at to
make sure that I initialized everything correctly.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-986611-cppcheck-uninitialized-variables into
lp
18 matches
Mail list logo
