cghislai has proposed merging lp:~widelands-dev/widelands/bug1205010 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1205010 in widelands: "segfault on dismantle enemy building"
https://bugs.launchpad.net/widelands/+bug/1205010
For more details
The proposal to merge lp:~widelands-dev/widelands/bug1205010 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
--
https://code.launchpad.net/~widelands-dev/widelands/bug12050
Just a general though that crossed my mind: we have many 'manual' test cases in
the last few days (like the one you describe in your last sentence). How about
starting a test suite with lua scenarios that can be automatically run (like
ts.wmf)? they would set up a starting condition (a bunch of
Review: Needs Fixing
--
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1205010.
___
Mailing list: https://launchpad.net/~widelands-dev
Indeed a proper test suite would be nice. and each bug fixed should have, if
possible, a test written to check for regression.
But as you said some handler function would be required. I may try to implement
that, but Im don't think that should be ready for b18. Maybe we could open a
blueprint on
> Indeed a proper test suite would be nice. and each bug fixed should have, if
> possible, a test written to check for regression.
> But as you said some handler function would be required.
I think starting out with a directory of .wmf files and run each in order from
a shell script (i.e. always
Can you make sure that this has no conflicts with trunk?
--
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1205010.
___
Mailing list: ht
I just resolved them
--
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1205010.
___
Mailing list: https://launchpad.net/~widelands-dev
P
Review: Approve
Thanks. I changed some nits and merged. Please let me know when you are not
happy about the changes I did and I can revert them in trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
Your team Widelands Developers is subscribed to branch
lp:~wi
9 matches
Mail list logo
