The proposal to merge lp:~widelands-dev/widelands/clang5-warnings-destructors
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
--
Your team Widelands Develo
Transient timeout on MacOS
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/clang5-warnings-destructors.
_
Continuous integration builds have changed state:
Travis build 2913. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/310474235.
Appveyor build 2722. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_wa
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 2913. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/310474235.
--
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Y
OK, the question was resolved per chat.
If you put the apple exclusion in the third-party headers, that's just 3 places
and will save you most of the noise.
--
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands Developers is subscrib
Review: Approve review
Just one question inline.
@bunnybot merge
Diff comments:
>
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc 2017-11-26 17:43:25 +
> +++ src/ai/defaultai.cc 2017-12-02 11:52:29 +
> @@ -450,13 +450,13 @@
>
Review: Approve test
I actually played this verson (wit a merge to trunk) during the tournament.
So this can go in. In can live with extra warnings for X-Code. Eventually
Ill adress them in some other branch.
Using
> #ifndef __APPLE__
> #endif
will not Help as ther are
a) to many such places
b)
Continuous integration builds have changed state:
Travis build 2910. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/310414924.
Appveyor build 2719. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_war
You could try surrounding the statements with:
#ifndef __APPLE__
#endif
if that helps, can you push the change to this branch? Note that I merged
trunk, so you'll have to pull first.
And don't worry, Trimard would have kicked my behind, too.
--
https://code.launchpad.net/~widelands-dev
SirVer: then I will stick with the Apple compiler. so we have bot of them.
I lost my game agains trimard on trunk, despite he did not even build a barack,
shame on me, sniff ;-)
--
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Your team Widelands De
I compile with GCc 5 and clang 4. I do not use the Apple shipped compiler nor
Xcode.
> Am 01.12.2017 um 17:33 schrieb Klaus Halfmann :
>
> Hell Gun,
>
> thats the Apple clang compile flavour
>> Apple LLVM version 9.0.0 (clang-900.0.38)
> that gives me:
>> warning: unknown warning group'-Wzero-
Hell Gun,
thats the Apple clang compile flavour
> Apple LLVM version 9.0.0 (clang-900.0.38)
that gives me:
> warning: unknown warning group'-Wzero-as-null-pointer-constant',
> ignored [-Wunknown-warning-option]
I have no Ida how it relates to clang 5.0
So bot compiles shoud do, As I think clang
I explicitly switched off the unknown warning group here:
http://bazaar.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/view/head:/src/third_party/gettext/gettext.h#L28
So, it's strange that you're still getting it. We have to make sure it's gone -
can you please eradicate you
Review: Approve compile, small test
compiled fien with clang 5.0 less noise, fine.
with OSX clang
Apple LLVM version 9.0.0 (clang-900.0.38)
Target: x86_64-apple-darwin17.2.0
Thread model: posix
InstalledDir:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Continuous integration builds have changed state:
Travis build 2894. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/309379186.
Appveyor build 2703. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_warn
The proposal to merge lp:~widelands-dev/widelands/clang5-warnings-destructors
into lp:widelands has been updated.
Description changed to:
Fixes the trivially fixable new warnings by Clang5.
https://code.launchpad.net/~hjd/widelands/travis-clang-5.0/+merge/334282 needs
to be merged first.
For
The proposal to merge lp:~widelands-dev/widelands/clang5-warnings-destructors
into lp:widelands has been updated.
Commit Message changed to:
Fixed diverse new warnings by clang 5.
- -Wunused-lambda-capture
- -Wzero-as-null-pointer-constant
- Missing destructor overrides
- std::max with 0
For m
> what is the problem with constructs like this one?
> - const auto read_terrains = [this, &table, &world](
> + const auto read_terrains = [&table, &world](
lambda capture 'this' is not used [-Wunused-lambda-capture]
> nitpicking : why did you drop "virtual" while adding "overrride"?
Because t
Mhh ravis has only this, unrelated Problem:
WARNING: The following packages cannot be authenticated!
gcc-7-base libgcc1 libstdc++6 libasan4 libatomic1 libcc1-0 libcilkrts5
libgomp1 libisl15 libitm1 liblsan0 libmpfr4 libmpx2 libquadmath0 libtsan0
libubsan0 cpp-7 libgcc-7-dev gcc-7 libstdc++-
Continuous integration builds have changed state:
Travis build 2878. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/308578740.
Appveyor build 2687. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_war
Continuous integration builds have changed state:
Travis build 2872. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/308118425.
Appveyor build 2681. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_war
Continuous integration builds have changed state:
Travis build 2853. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/307509487.
Appveyor build 2663. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_clang5_wa
GunChleoc has proposed merging
lp:~widelands-dev/widelands/clang5-warnings-destructors into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Do not review
The proposal to merge lp:~widelands-dev/widelands/clang5-warnings-destructors
into lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
--
Your team Widela
GunChleoc has proposed merging
lp:~widelands-dev/widelands/clang5-warnings-destructors into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/clang5-warnings-destructors/+merge/334286
Do not review
25 matches
Mail list logo
