The proposal to merge lp:~widelands-dev/widelands/compiler-warnings-201908-2
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
--
Your team Widela
Review: Approve
local tests ok
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler-warnings-201908-2.
___
Mailing
The UI test sometimes fails because it takes too long for the game to close. I
have implemented a fix in one of my other branches. Will rerun the Travis job.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is
Mhh,one test in travis fails
test/maps/plain.wmf/scripting/test_ui.lua ...
Running Widelands ... FAIL
But only for GCC_VERSION="4.9" BUILD_TYPE="Debug" ?
will run the test loocally, too
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team
Review: Approve
Locally commpiles without issues. Start upto Lobby was fine.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler-warnings-201908-2.
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 5399. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/581705807.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Thanks for the review!
I already did a code review on your branch, I guess you overlooked it.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
Review: Approve
* Replaced:
- widelands_ball_of_mud
+ widelands_options
-> fine
* Codestyle: using this for a member function makes no sense.
* Smuggeled in some USE_XDG handling :-)
Will compile and start this, not doing much testing.
Please: review my refactor_gamehost before merging it
Continuous integration builds have changed state:
Travis build 5399. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/581705807.
Appveyor build 5169. State: success. Details:
Continuous integration builds have changed state:
Travis build 5378. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/579360487.
Appveyor build 5148. State: success. Details:
Continuous integration builds have changed state:
Travis build 5378. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/579360487.
Appveyor build 5148. State: success. Details:
Review: Resubmit
I'm done checking the logs, so this is ready for review now.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler-warnings-201908-2.
/widelands/compiler-warnings-201908-2/+merge/372111
Do not send the merge command yet, I want to check the Travis/AppVeyor logs
first.
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands.
=== modified
13 matches
Mail list logo
