The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_20170619
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20170619/+merge/325952
--
Your team Widelands Develope
Excellent :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20170619/+merge/325952
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_20170619.
___
Mailing lis
Review: Resubmit
Supressed the warning locally,
created [1699852] for the MapTriangleReg.
So when bunnybot is happy this should go in.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20170619/+merge/325952
Your team Widelands Developers is subscribed to branch
lp:~widel
Yep, those map region templates are complex. Let's open a bug and leave them
for another branch.
Travis does compile the test code, because its running the tests too. It does
not generate the warnings though.
You can't rewrite those testing macros, because that's code written by Boost.
All you
The later warnings come from the testcode only (I think travis does not comile
this).
Ill try to get rid of them like you did with the other ones.
The first one is a problem with template instantiation.
The compiler must instantiate them whenver he needs to, resulting
in some duplicate code to be
This:
compiler_warnings_20170619/src/wui/interactive_base.cc:168:34: warning:
instantiation of function
'Widelands::MapTriangleRegion,
unsigned short>::MapTriangleRegion' required here, but no definition is
available [-Wundefined-func-template]
Widelands::MapTriangleR
Comipling this again (after pulling from _this_ bracnh :-)
still get warning like:
compiler_warnings_20170619/src/wui/interactive_base.cc:168:34: warning:
instantiation of function
'Widelands::MapTriangleRegion,
unsigned short>::MapTriangleRegion' required here, but no definition is
I am still working on the format macros - older versions of Clang don't
recognize the -pedantic version.
In the meantime, are you still getting any warnings except for the
"-Wundefined-func-template" ones with the map regions?
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warn
Thanks for setting this up.
I have copied over the information from the commit messages.
>From the Travis logs, I noticed that GCC uses "-Wformat" and Clang uses
>"-Wformat-pedantic". I have an idea for a more elegant solution for this. I am
>against switching off the printf warnings, because t
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_20170619
into lp:widelands has been updated.
Commit Message changed to:
Fixed diverse compiler warnings:
- Fixed floor/double warnings
- Removed assertion in Battle::opponent that would always evaluate to true
- Switched off "di
Continuous integration builds have changed state:
Travis build 2325. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/244653007.
Appveyor build 2153. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_compiler_w
Klaus Halfmann has proposed merging
lp:~widelands-dev/widelands/compiler_warnings_20170619 into lp:widelands.
Requested reviews:
GunChleoc (gunchleoc)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20170619/+merge/325952
This is the alternative fo
12 matches
Mail list logo
