The proposal to merge lp:~widelands-dev/widelands/fh1-winconditions into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
--
Your team Widelands Developers is subscribed t
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1-winconditions.
___
Mailing list: htt
Review: Approve code review
Code Revire is ok for me.
In case of an error some layout may be broken, well. We will find that.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/
Sorry, wrong branch :-S
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1-winconditions.
___
Mailing list: https://launchpad.net
Review: Approve testing
This looks really good now :-)
Played an hour or so but no crash anymore. The output of 'new size' is a bit
annoying, i guess it switches between Kilobytes and Bytes (?):
TransientCache: Dropping 11 bytes, new size 4082. [...]
The crash is this bug: https://bugs.launchpad.net/widelands/+bug/1648785
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fh1-winconditions into lp:widelan
Yes, it must be a problem that we have in trunk already - the worst thing that
should happen here is reverting to the old font renderer if the text can't be
parsed and the ending up with empty text or lots of visible tags.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/
I played this some time now and got an ugly crash, here:
Cmd_EnemyFlagAction::execute player(3): flag->owner(4) number=4
Assertion failed: (it != entries_.end()), function drop, file
/Users/klaus/develop/widelands-repo/fh1-winconditions/src/graphic/texture_cache.cc,
line 79.
3 libsystem_c.dyl
Continuous integration builds have changed state:
Travis build 2179. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/231575243.
Appveyor build 2014. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fh1_wincon
Uhm, this is all lua, what would be the way to test this?
I cannot judge much about that code.
I will however compile the code and play around with some winconditions
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-winconditions/+merge/323987
Your team Widelands Developers is requested
GunChleoc has proposed merging lp:~widelands-dev/widelands/fh1-winconditions
into lp:widelands.
Commit message:
Converted win condition scripts to new font renderer. Formatting functions for
the new renderer live in data/scripting/richtext.lua
Requested reviews:
Widelands Developers (wideland
11 matches
Mail list logo
