The proposal to merge lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
--
Your team Widela
Hasi50 approved the code for this branch in IRC.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options.
Continuous integration builds have changed state:
Travis build 1751. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
('The read operation timed out',)
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 1751. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
HTTP Error 500: Internal Server Error
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 1751. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details:
Bunnybot encountered an error while working on this merge proposal:
('The read operation timed out',)
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
Your team Widelands Developers is subscribed to branch
Continuous integration builds have changed state:
Travis build 1751. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/182848448.
Appveyor build 1591. State: success. Details:
Both of these problems are happening in trunk already, so this needs a bug
report for trunk, not for this branch.
This bug doesn't implement the size change, it only relayouts the contents of
the Options panel and adjust some bits of the toolkit to make this happen.
--
Review: Needs Information
OK, I tryed this with a two Monitor layout on OSX.
Main Monitor Full-HD plus the "normal" Laptop Display.
Works for all Tabs using f back and forth.
Small Problem; when on the Second Scrren the normalw window
moves quite quite a bit to the right, but still is visbile.
Thanks for the clang output - I replaced it with a constant. It is set later in
the layout() function. I also did my best on your nit :)
And yes, this is about the f button.
Should the overall size not be correct with multiscreen setups, that will be a
separate bug.
--
Review: Needs Fixing
Clang complains:
fsmenu_fullscreen_4_options/src/ui_fsmenu/options.cc:139:25: error: field
'column_width_' is uninitialized when used here [-Werror,-Wuninitialized]
column_width_ / 2,
fsmenu_fullscreen_4_options/src/ui_fsmenu/options.cc:145:27:
ered_text_->height(), h);
> + }
> set_desired_size(w, h);
> set_size(w, h);
> }
> }
>
> -Statebox::~Statebox() {
> -}
> -
> /**
> * Set the enabled state of the checkbox. A disabled checkbox cannot be
> cli
The proposal to merge lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options
into lp:widelands has been updated.
Commit Message changed to:
The Options window now relayouts itself for fullscreen switch. Includes changes
to checkbox, dropdown, listselect and spinbox in order to make it happen
rge of
lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options into lp:widelands.
=== modified file 'src/ui_basic/checkbox.cc'
--- src/ui_basic/checkbox.cc 2016-10-25 08:11:31 +
+++ src/ui_basic/checkbox.cc 2016-12-10 10:30:36 +
@@ -38,6 +38,8 @@
const std::string& tooltip_tex
16 matches
Mail list logo
