This basically fixes bug #1550568 in a better way in terms of performance.
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/improve-restool into lp:widelands
Review: Approve testing
Works fine :-)
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/improve-restool.
___
Mailing list: https:/
@tiborb95
Yes, an empty undo action is created. Unfortunately, it doesn't seem to be
trivial to fix because of all the "draw tool" mess.
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/
No problem, I understand this is out of scope of this fix
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/improve-restool.
___
Maili
Review: Approve
Exactly how I meant it!
BTW, how the game behaves if no fields are changed? Is "empty" undo action
created?
I have not tested it
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~wide
And similarly, for increasing resources - do nothing if resources are at max
and for decreasing do nothing if resources are currently at 0.
?
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is requested to review the proposed mer
The proposal to merge lp:~widelands-dev/widelands/improve-restool into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
--
Your team Widelands Developers is subscribed to br
Miroslav Remák has proposed merging lp:~widelands-dev/widelands/improve-restool
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
--
Your team Widelands Developers
Continuous integration builds have changed state:
Travis build 850. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/116499709.
Appveyor build 684. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_improve_rest
It looks good to me, just look at small question in diff
Diff comments:
>
> === modified file 'src/editor/tools/editor_set_resources_tool.cc'
> --- src/editor/tools/editor_set_resources_tool.cc 2016-01-14 22:09:24
> +
> +++ src/editor/tools/editor_set_resources_tool.cc 2016-03-16 21
Done.
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/improve-restool into lp:widelands.
___
Mailing list: http
Thanks for the fix! :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/improve-restool.
___
Mailing list: https://l
12 matches
Mail list logo
