cghislai has proposed merging lp:~widelands-dev/widelands/minimap into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #846409 in widelands: "Improving the load game dialog"
https://bugs.launchpad.net/widelands/+bug/846409
Bug #1202146 in widelands:
The proposal to merge lp:~widelands-dev/widelands/minimap into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge/176945
--
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge
Review: Needs Fixing
Finally went over this. The use of InMemoryImage is fine as it never stays
around to be a problem with graphic system reinitialization.
--
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge/176945
Your team Widelands Developers is subscribed to branch
lp:~wi
chees -- me and the save comment button. I forgot to mention: I have some
comments and did some small fixes that you should review/address.
--
https://code.launchpad.net/~widelands-dev/widelands/minimap/+merge/176945
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widela
Review: Approve
Just for the future: Please do merge trunk in a separate commit. It is pretty
much impossible to look at the changes you did manully in the last commit, so
it is harder for me to see how you adressed them.
Otherwise: lgtm, merged.
--
https://code.launchpad.net/~widelands-dev/wi
5 matches
Mail list logo
