Notabilis has proposed merging lp:~widelands-dev/widelands/net-checkpwd-command
into lp:widelands.
Commit message:
Checking metaserver password without doing a full login.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/
Continuous integration builds have changed state:
Travis build 5120. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/540143585.
Appveyor build 4902. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_net_checkp
The proposal to merge lp:~widelands-dev/widelands/net-checkpwd-command into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/net-checkpwd-command/+merge/368225
--
Your team Widelands Developers is subscr
Review: Approve
Code LGTM, just some small nits for the comments
Diff comments:
> === modified file 'src/network/internet_gaming.cc'
> --- src/network/internet_gaming.cc2019-05-25 08:25:55 +
> +++ src/network/internet_gaming.cc2019-06-01 12:37:21 +
> @@ -405,6 +452,12 @@
>
Is fixed, thanks!
--
https://code.launchpad.net/~widelands-dev/widelands/net-checkpwd-command/+merge/368225
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/net-checkpwd-command.
___
Mailing list: https://launchpad.net
The related change to the metaserver has been deployed, so this branch can be
tested and merged.
Bunnybot fails due to transient errors.
--
https://code.launchpad.net/~widelands-dev/widelands/net-checkpwd-command/+merge/368225
Your team Widelands Developers is subscribed to branch
lp:~widelands
Review: Approve
Tested and working :)
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/net-checkpwd-command/+merge/368225
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/net-checkpwd-command.
___
7 matches
Mail list logo
