The proposal to merge lp:~widelands-dev/widelands/notifications_sound into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/notifications_sound/+merge/318763
--
Your team Widelands Develop
No wonder this looks familiar - I have a whole series of these. Untangling the
Widelands dependencies is a long-term project, but I hope to eventually speed
up compiling and linking.
So, these branches aim at not changing any functionality really except for code
quality.
Thanks for the
Review: Approve
Why does the description of this merge request sounds familiar? Strange... ;-)
But the diff looks good to me and the sounds are playing in-game so it seems to
be alright.
I don't know much about cmake so I can't say much about moving widelands.h. Is
there a real reason to move
/_widelands_dev_widelands_notifications_sound-1860.
--
https://code.launchpad.net/~widelands-dev/widelands/notifications_sound/+merge/318763
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/notifications_sound into lp:widelands
.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/notifications_sound/+merge/318763
--
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/notifications_sound
5 matches
Mail list logo
