Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread GunChleoc
Sounds like this bug: https://bugs.launchpad.net/widelands/+bug/1535065 And I thought I had it fixed. -- https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rename_editor_files.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread Klaus Halfmann
Mhh, looks like _setting_ the playerpos succeed but nrplayers is inconsistant, mmh. Should be unrelated to this branch. -- https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rena

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread Klaus Halfmann
Ah, here is the assertion: WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202). WARNING: Player 2 has no starting position - illegal coordinates (-1, -1). WARNING: Player 1 has no starting position - illegal coordinates (29508, 22202). WARNING: Player 2 has no starting

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread Klaus Halfmann
perhaps to fast: / Got a Crash in creating a radom Map 80x80 for 3 players in Widelands::Map::get_starting_pos(unsigned char) const + 130 (map.h:205) editor_tool_set_starting_pos_callback(Widelands::TCoords const&, -- https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merg

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/rename_editor_files into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093 -- Your team Widelands Developers is subscrib

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread GunChleoc
That was fast, thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rename_editor_files. ___ Mailing list: h

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread Klaus Halfmann
Review: Approve OK, found only the expected renamings. OK, Compiles on OSX I have seen no actual code changes -> Approve -- https://code.launchpad.net/~widelands-dev/widelands/rename_editor_files/+merge/291093 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/r

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/rename_editor_files into lp:widelands

2016-04-06 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/rename_editor_files into lp:widelands. Commit message: Removed "editor_" prefix from editor source files. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelan