The proposal to merge lp:~widelands-dev/widelands/run-asan into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/run-asan/+merge/334227
--
Your team Widelands Developers is subscribed to branch
lp:~wide
Continuous integration builds have changed state:
Travis build 2834. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/306932194.
Appveyor build 2644. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_run_asan-2
Well spotted :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/run-asan/+merge/334227
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/run-asan.
___
Mailing list: https://launchpad.net/~widelan
One nit:
In print help is a wrong short form option:
> echo "-a or --help Print this help."
should be
> echo "-h or --help Print this help."
-a is used for asan.
--
https://code.launchpad.net/~widelands-dev/widelands/run-asan/+merge/334227
Your team Widelands Developers is
Let's wait for the Travis and Appveyor logs before merging - I'd like to have a
look at those, just in case.
--
https://code.launchpad.net/~widelands-dev/widelands/run-asan/+merge/334227
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/run-asan.
___
> you switched from $BUILDTYPE to BUILD_TYPE
Yes, for naming consistency - all other BUILD option have an underscore.
I have tested this on Ubuntu for both compilers - I used the
multiplayersetupgroup bug for it.
Windows support is still buggy and we can't use it on AppVeyor yet:
https://githu
Review: Approve compile, review, test
compiled, tried to open a network game,
cancel on map selection, selected map
later in Game dialog, got
==67295==ERROR: AddressSanitizer: heap-buffer-overflow on address
0x612000e84260 at pc 0x000106ba4099 bp 0x7ffeea711170 sp 0x7ffeea711168
READ of size 4
Loook good for me:
you switched from $BUILDTYPE to BUILD_TYPE
I will compile this now and try to reproduce one of the bugs I found.
Ill try to do this on Ubuntu as well, but will need som preparation?
Do we have clang compiler for windows?
--
https://code.launchpad.net/~widelands-dev/widelands/
GunChleoc has proposed merging lp:~widelands-dev/widelands/run-asan into
lp:widelands.
Commit message:
Added compile options for AddressSanitizer and for choosing the compiler. 2 new
warning flags for the clang compiler.
Requested reviews:
Tino (tino79)
For more details, see:
https://code.la
9 matches
Mail list logo
