Review: Approve
Great - LGTM :)
Let's make sure to test the translation once we have this in trunk + translated.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-collectors/+merge/312092
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wideland
I have actually already tried disabling the warnings in Windows instead and am
waiting for the AppVeyor build. If it succeeded, I will remove all those nasty
#ifdefs again.
There are also some more issues in clang that I want to fix before this is
ready for review. The reason that this is an op
Character encoding is so not fun :(
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix_map_upload/+merge/312300
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelan
Thanks - all fixed.
I was just thinking - we also have fix_lua_tabs.py, which is run when we update
the translations.
How about having 1 central script "fix_formating.py" that does the following:
- fix_lua_tabs.py
- run_clang_format.py
- run pyformat over utils.
This script could then be calle
The proposal to merge lp:~widelands-dev/widelands/automate_clang-format into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
--
Your team Widelands Develope
Will do that in this branch then.
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/automate_clang-format.
___
Mailing list: htt
GunChleoc has proposed merging
lp:~widelands-dev/widelands/automate_clang-format into lp:widelands.
Commit message:
Moved utils/fix_lua_tabs.py to utils/fix_formatting.py and added calls to
clang-format any pyformat.
Requested reviews:
GunChleoc (gunchleoc)
SirVer (sirver)
For more
Review: Resubmit
Done. Never mind the big diff for udate_authors.py, the relevant bit is the
removed call at the bottom. Pyformat already in action here ;)
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to b
Thanks for the review!
So, pyformat doesn't fix long lines, need to keep that in mind.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/automate_clang-format/+merge/312287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/automate_clang-for
GunChleoc has proposed merging
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Added script to
I have tested the translation in trunk now and it works :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-collectors/+merge/312092
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-collectors.
___
Mailin
This is WaresQueue does in the cleanup:
if (filled_ && owner_.get_economy())
owner_.get_economy()->remove_wares(index_, filled_);
filled_ = 0;
etc...
I guess we should to the same for the workers queue now, since it's now more
like the waresqueue and not like th
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1624216-horsepocalypse/+merge/310221
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1624216-horsepocalypse into lp:widelands.
_
The proposal to merge lp:~widelands-dev/widelands/bug-1624216-horsepocalypse
into lp:widelands has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1624216-horsepocalypse/+merge/310221
--
Your team Widelands Develo
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1644553-buildhelp-button into lp:widelands.
Commit message:
Revert to calling raw delete for FieldActionWindow.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/glossary_checks into
lp:widelands.
Commit message:
Added a Python script to do automated glossary checks for translations.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net
Review: Needs Fixing
Can you put the RST comments directly above each method? This will make the
code easier to read and avoid accidentally documenting this twice in the future.
I have also added come nits and ideas.
Diff comments:
> === modified file 'src/scripting/lua_map.cc'
> --- src/scrip
Review: Approve
I have used the new test to confirm that this fixes the bug.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-supply/+merge/312421
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-supply.
__
The reason that the warehouse statistics don't list them is that people might
try to set a policy on them. Players might still be interested in the inventory
though.
--
https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763
Your team Widelands Developers is request
We can use destroy() in the interactive player, so I have done that now.
The fieldaction call has to be a raw delete, otherwise crash boom bang.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildhelp-button/+merge/312429
Your team Widelands Developers is requested to review
Forgot to say: adding window = nullptr after the destroy() call doesn't help,
it still crashes.
Since we should slowly go over all our remaining delete calls anyway, I'd say
let's get this in to get rid of the crash ASAP.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildh
Looks great :)
The archive links are hard to see because they are sort of beige on beige, can
you make them green?
Also - News Archiv: -> News Archive:
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Developers is subscribed to branch
Background went dark now, looks good :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widela
If that directory does the same job as utils does on Widelands, yes.
Diff comments:
> === added directory 'utils'
> === added file 'utils/fix_formatting.py'
> --- utils/fix_formatting.py 1970-01-01 00:00:00 +
> +++ utils/fix_formatting.py 2016-12-04 06:57:43 +
> @@ -0,0 +1,51 @@
> +#!
Review: Resubmit
I am running out of time for working on this, so I'm in favour of getting this
in now. We can always do another round of cleanups next year.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed
GunChleoc has proposed merging
lp:~widelands-dev/widelands/codecheck_remove_2_rules into lp:widelands.
Commit message:
Remove 2 codecheck rules which are now covered by calling clang-format:
- long_line: causes frequent Travis fails
- illegal_space_before: conflicts with clang-format in the
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/codecheck_remove_2_rules/+merge/312526
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/codecheck_remove_2_rules.
___
Mailing list: https://launchp
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1647033-immovable-packet-no into lp:widelands.
Commit message:
Immovables now have a dynamic packet number, so maps will still load with Build
19: The packet number is only increased if the immovable has a former building
Review: Approve
Tested and LGTM. Let's wait for Travis then merge.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildhelp-button/+merge/312429
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1644553-buildhelp-button.
_
The proposal to merge lp:~widelands-dev/widelands/bug-1644553-buildhelp-button
into lp:widelands has been updated.
Commit Message changed to:
Fixed crash with destroying UniqueWindow in FieldActionWindow.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-bui
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_201611.
___
Mailing list: https://launchp
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed a series of compiler warnings for clang and WIndows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20161
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed a series of compiler warnings for clang and Windows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20161
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed some compiler warnings for clang and WIndows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merg
Yep, 16 players not fitting is a known issue. Those screens need a complete
redesign, and I didn't want your AI testing to have to wait for this - might be
months.
Thanks for the review!
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect/+merge/310744
Your team
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildhelp-button/+merge/312429
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1644553-buildhelp-button.
___
Mailing list: https:/
OK, moved :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website.
___
GunChleoc has proposed merging lp:~widelands-dev/widelands/table_multiselect
into lp:widelands.
Commit message:
Let the user select multiple entries in a table using Ctrl/Shift + Click and
Ctrl+A. The new table mode is used in the messages window and in game/replay
deleting.
Requested reviews
The proposal to merge lp:~widelands-dev/widelands/table_multiselect into
lp:widelands has been updated.
Commit Message changed to:
Let the user select multiple entries in a table using Ctrl/Shift + Click and
Ctrl+A. The new table mode is used in the messages window and in game/replay
deleting.
Thanks for testing! Savegames as a rule aren't backwards compatible, only
forwards compatible. The important thing is that maps can be loaded with older
versions :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1647033-immovable-packet-no/+merge/312530
Your team Wid
The proposal to merge lp:~widelands-dev/widelands/glossary_checks into
lp:widelands has been updated.
Commit Message changed to:
Added a Python script to do automated glossary checks for translations. It
enlists the help of Hunspell and 'misuses' the Transifex note field in order to
reduce noi
The proposal to merge lp:~widelands-dev/widelands/glossary_checks into
lp:widelands has been updated.
Description changed to:
After the British English fiasco in Build 19, I decided it would be good to
have some glossary checks for translations. We are using this kind of check at
my workplace,
Review: Resubmit
I guess I had quite a few new ideas after submitting this merge request
should be done now. I have already dogfooded this with my own locale and fixed
up a number of translations thanks to this check :)
Will create a zip of the results for the translators so they can check
My progress is slow, so I'll remove this from view to give bunnybot a break.
--
https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/notifications_economy_window.
The proposal to merge lp:~widelands-dev/widelands/notifications_economy_window
into lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572
--
Your team Wide
Review: Approve
I tried to give it some testing on the alpha site, but I guess you already
switched it off again?
Looking at the code, just 1 tiny nit:
The filename contain characters -> The filename contains characters
--
https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_up
It still generates errors sometimes, which then would fill up this tread with
comments - I expect the branch to sit around inactive for a month, because I
will be travelling.
--
https://code.launchpad.net/~widelands-dev/widelands/notifications_economy_window/+merge/311572
Your team Widelands Dev
Review: Approve
Code LGTM, just 1 nit. Not tested.
Diff comments:
>
> === modified file 'src/wui/field_overlay_manager.cc'
> --- src/wui/field_overlay_manager.cc 2016-12-03 12:51:06 +
> +++ src/wui/field_overlay_manager.cc 2016-12-09 10:05:43 +
> @@ -39,7 +39,8 @@
> Vector2i(
I still get internal server errors for:
* evil characters in new topic title
* evil characters in map (I used them in name, author, description, hint,
filename and uploader comment)
* evil characters in image filename when uploading to the wiki
Since this branch does fix some issues, let's get i
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/emergency_log/+merge/312949
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/emergency_log into lp:widelands.
___
Mai
Thanks!
This was tested on the forum before I added the last tweaks, so since the crash
is not caused by this branch, let's get this in.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1426465-scenario-timings/+merge/39
Your team Widelands Developers is subscribed
GunChleoc has proposed merging
lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options into lp:widelands.
Commit message:
The Options window now relayouts itself for fullscreen switch.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1398733 in widelands
The proposal to merge lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options
into lp:widelands has been updated.
Commit Message changed to:
The Options window now relayouts itself for fullscreen switch. Includes changes
to checkbox, dropdown, listselect and spinbox in order to make it happen.
The proposal to merge lp:~widelands-dev/widelands/critter_editor_categories
into lp:widelands has been updated.
Commit Message changed to:
Editor categorized item selection menu overhaul:
- Overhauled the selection menu for critters to give them categories
- Made the background a bit darker, bec
GunChleoc has proposed merging
lp:~widelands-dev/widelands/map-descriptions-and-hints into lp:widelands.
Commit message:
Moved hints from map decriptions to hints for the Last Bastion and Rendez-vous
maps.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https
GunChleoc has proposed merging
lp:~widelands-dev/widelands/productionsite_military_cleanup into lp:widelands.
Commit message:
The ProductionSiteDescr constructor still contained some checks from the time
when they used to inherit from MilitarysiteDescr. Removed this obsolete code
and made
Thanks for the clang output - I replaced it with a constant. It is set later in
the layout() function. I also did my best on your nit :)
And yes, this is about the f button.
Should the overall size not be correct with multiscreen setups, that will be a
separate bug.
--
https://code.launchpad.n
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1625502-tips-in-help into lp:widelands.
Commit message:
Convert editor/game tips to Lua and display them in the in-editor/in-game help.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1625502 in
Both of these problems are happening in trunk already, so this needs a bug
report for trunk, not for this branch.
This bug doesn't implement the size change, it only relayouts the contents of
the Options panel and adjust some bits of the toolkit to make this happen.
--
https://code.launchpad.ne
Does somebody have the time to fix the nit for me? Compiling Widelands on my VM
takes hours.
--
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/actionconfirm_improvemen
Thanks for the nit - fixed :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
The looking glass doesn't look round - that effect is probably caused by the
shading.
--
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button/+merge/313058
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/reset_zoom_button i
Duh, I let Travis do the compiling for me :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/actionconfirm_improvements/+merge/312301
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/actionconfirm_improvements.
___
You're welcome :)
I wanted it for Widelands, so why not have it for the website as well. You made
me aware of pyformat in the first place!
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch lp:wideland
Review: Approve
Code LGTM, not tested. Some tiny nits.
Diff comments:
>
> === modified file 'src/logic/map_objects/immovable.h'
> --- src/logic/map_objects/immovable.h 2016-11-22 19:11:01 +
> +++ src/logic/map_objects/immovable.h 2016-12-14 22:13:01 +
> @@ -202,9 +202,10 @@
> MO_D
For inspiration:
http://www.accessfirefox.org/Page_Zoom_Buttons.php
I would like to expand the menu to have +/- buttons as well, so we will need to
make sure to keep a layered version of the icon around.
--
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button/+merge/313058
Your
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/map-descriptions-and-hints/+merge/312968
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map-descriptions-and-hints.
___
Mailing list: ht
Review: Approve
I think this is a great idea, code LGTM.
I have already edited the positions on the live site - I used 2 digit numbers,
so it will be easier to move/add forums.
--
https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357
Your team Widelands Developers
Why do you do _plrpoints[k] = nil and not _plrpoints[k] = 0? The crashy line is
probably trying to calculate nil + 1.
--
https://code.launchpad.net/~widelands-dev/widelands/wood_gnome_infinite_trees/+merge/313397
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/
Review: Approve
Code LGTM, not tested.
--
https://code.launchpad.net/~widelands-dev/widelands/wood_gnome_infinite_trees/+merge/313397
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/wood_gnome_infinite_trees.
___
Mai
Thanks for the fix :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
A quick comment to the comments:
The reordering was done to make the UI more consistent, e.g. that we always
have arable terrains first, or that immovables look clean and not all over the
place.
The different terrain window sizes were probably done on purpose as well to
group the same types of
+1 to more documentation :)
How about adding a small code example to illustrate, and/or turning this into a
list? Kaputtnik and I fiddled with the format for this with the (still
incomplete) Tribes units and animations:
https://wl.widelands.org/docs/wl/autogen_toc_lua_tribes_buildings/
https:/
OK, let's get the information in then and make it more readable later. I am
planning to do more work on the documentation once I have cleared my backlog of
branches a bit.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/document_mine/+merge/313509
Your team Widelands Deve
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1627537-window-mouserelease into lp:widelands.
Commit message:
Let UI::Window only handle mouserelease when it actually handles it.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1627537 in widelands
Review: Approve
Not tested, code LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/unique_ptr_coroutine/+merge/313880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/unique_ptr_coroutine.
___
Mailing lis
Review: Approve
One tiny nit - it's up to you if you want to change it. Not compiled or tested.
Diff comments:
> === modified file 'src/sound/sound_handler.cc'
> --- src/sound/sound_handler.cc2016-10-22 18:19:22 +
> +++ src/sound/sound_handler.cc2017-01-03 20:52:54 +
> @@
Review: Approve
LGTM - just 1 nit as to phrasing.
Not tested.
Diff comments:
>
> === modified file 'data/campaigns/tutorial02_warfare.wmf/scripting/texts.lua'
> --- data/campaigns/tutorial02_warfare.wmf/scripting/texts.lua 2016-11-30
> 09:14:27 +
> +++ data/campaigns/tutorial02_warfare.wm
Review: Approve
I went through the code - mostly minor nits. Feel free to merge when you have
addressed them as you see fit and you are happy with the level of testing.
Diff comments:
>
> === modified file 'data/campaigns/bar02.wmf/scripting/mission_thread.lua'
> --- data/campaigns/bar02.wmf/s
Review: Approve
Added some tiny nits - feel free to merge any time once you have addressed them
:)
Diff comments:
> === modified file 'src/scripting/lua_map.cc'
> --- src/scripting/lua_map.cc 2016-12-14 22:11:52 +
> +++ src/scripting/lua_map.cc 2017-01-06 09:18:41 +
> @@ -3974,7 +3977
@toptopple: Your ideas are unrelated to this branch, we should create a new bug
for them though - will yo do the honours?
@SirVer: I'd like to hear you opinion on
https://code.launchpad.net/~widelands-dev/widelands/critter_editor_categories/+merge/312967/comments/814078
--
https://code.launchpa
Looks good. This is a great change, thanks! :)
Regarding the clang-format thing, let's leave it as it is. The benefits of
running it are far greater than the few awkward formattings that we get.
--
https://code.launchpad.net/~widelands-dev/widelands/animation_manager/+merge/313879
Your team Wide
Thanks for testing! I will see about making the terrain menus the same width
when I get home.
@topopple: while the explanation is looking awkward with the duck now, it is
old code in a superclass for the terrain, immovables and animals tools.
Implementing a ? button will mean quite a bit of new
@Klaus: could you please double-check if we have an open bug for the issue? I'm
still on the road and short on time.
--
https://code.launchpad.net/~widelands-dev/widelands/unique_ptr_coroutine/+merge/313880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/unique
I like that idea :)
--
https://code.launchpad.net/~widelands-dev/widelands/sound_improvements/+merge/314035
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/sound_improvements.
___
Mailing list: https://launchpad.net/~
1 quick comment - will have to look at the rest later.
Diff comments:
> === modified file 'src/game_io/game_player_economies_packet.cc'
> --- src/game_io/game_player_economies_packet.cc 2016-08-04 15:49:05
> +
> +++ src/game_io/game_player_economies_packet.cc 2017-01-10 18:04:24
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/casern_campaign/+merge/314208
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/casern_campaign.
___
Mailing list: https://launchpad.net/~widelands-
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/feature-test-supply-crash/+merge/312422
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/feature-test-supply-crash.
___
Mailing list: https://launc
This is a great change, thanks for taking it on and staying with it :)
--
https://code.launchpad.net/~widelands-dev/widelands/production_statistics/+merge/314283
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/production_statistics.
@toptopple: As I said, the code is in a superclass. Deactivating it for the
animals only is more complicated than implementing the ? button, and would lead
to really bad code that we would need to remember to rip out again later.
I really am in favour of implementing your suggestion, just not in
Terrain menus now have a uniform width of 6.
Now that I could look at it again, I know why I gave them different width: The
second row was all mountains for all tabs. This is now no longer true. Somebody
please give it a spin to make sure that this change is indeed better.
--
https://code.launc
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/critter_editor_categories/+merge/312967
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/critter_editor_categories.
___
Mailing list: http
Ready to go then :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/unique_ptr_coroutine/+merge/313880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/unique_ptr_coroutine.
___
Mailing list: ht
Review: Approve
Still need to compile & test, code LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/economy_save_load_debug/+merge/314453
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy_save_load_debug.
__
Linguistic proofreading done.
Diff comments:
>
> === added file 'templates/wiki/backlinks.html'
> --- templates/wiki/backlinks.html 1970-01-01 00:00:00 +
> +++ templates/wiki/backlinks.html 2017-01-15 12:03:32 +
> @@ -0,0 +1,38 @@
> +{% extends 'wiki/base.html' %}
> +{% load wiki
You have a codecheck error now:
/home/travis/build/widelands/widelands/src/scripting/lua_game.cc:882: Trailing
whitespace at end of line
I have set my editor to kill trailing whitespaces automatically when saving,
maybe your editor can do that too?
--
https://code.launchpad.net/~widelands-dev/
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images into lp:widelands.
Commit message:
Blit pictorial checkboxes pixel perfect.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1654989 in widelands: "Editor terrain
Review: Approve
Code LGTM :)
While we're touching this function, I want to change process_requests to a
pointer to signal that it's being changed, waiting for the compiler before I
push my change.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1656671/+merge/315075
Your team Widela
Done :)
@Klaus: You can't open current savegames with b19 anymore. It should work the
other way around though.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1656671/+merge/315075
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1656671.
__
It's the little things that count... :P
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images/+merge/315095
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images.
1801 - 1900 of 4401 matches
Mail list logo
