Review: Approve
Tests are OK, this can go in now :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1523165/+merge/280397
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1523165.
___
Mailing list: http
Code LGTM, will test.
--
https://code.launchpad.net/~widelands-dev/widelands/build_animation/+merge/281287
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/build_animation into lp:widelands.
___
Ma
Review: Approve
Tested :)
--
https://code.launchpad.net/~widelands-dev/widelands/build_animation/+merge/281287
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/build_animation.
___
Mailing list: https://launchpad.net/
Thanks. Could someone please merge my approved branches, unless they contain
difficult merge conflicts? It will take some time until I can do this myself
again.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/279646
Your team Widelands Developers is subscribed to branc
Why could the savegame not be loaded? We might have changed a packet version
somewhere in the meantime... anyway, this branch is UI only, and the savegae
not loading is a different bug - if it is a bug.
The screenshot bug is also unrelated to this branch.
--
https://code.launchpad.net/~wideland
Making the buttons for climate and resources narrower might create problems
with translations, so I'd rather leave them as they are for now.
> BTW is it possible to have more then 3 lines before and after the changed
> lines?
I don't understand the question.
--
https://code.launchpad.net/~wide
Thanks for all the reviews :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-536409/+merge/280352
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/editor_new_map.
___
Mailing list: https://launchpad.net/~wi
I can't compile or test right now, but code LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/clang_warnings/+merge/281383
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/clang_warnings into lp:widelands.
__
Look for Player::m_building_stats for where the building info is stored.
--
https://code.launchpad.net/~widelands-dev/widelands/ai_ship_tweaks/+merge/280192
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_ship_tweaks.
Yes, I branched this off another branch rather than off trunk, so this error
message can happen. The prerequitise branch has been merged already, so it's
safe.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-536409/+merge/280352
Your team Widelands Developers is subscribed to branch
Only SirVer and I have the necessary privileges on Transifex to push
translations. So, the new translation templates will have to wait until I get
back home.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/279646
Your team Widelands Developers is subscribed to branch
Everybody who is on widelands-dev can merge into trunk :)
--
https://code.launchpad.net/~widelands-dev/widelands/missing_worker_animations/+merge/281365
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/missing_worker_animations.
_
Could you go through the map saver and have a look at other packets that we
don't need?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1526903 into lp:wid
> But there is another issue with the number of players: Open editor, open "set
> players", set number of players to two but place only one player to the map.
> Save the map and after reload the map the "set player" window will always show
> two players. If you try to start a game with this map, a
Review: Approve
I agree that it is an improvement.
Since I'm still on he dead slow virtual machine, I will give my OK if somebody
who can reproduce the fuzzy roads does some testing to confirm that the problem
is fixed on their machine - I expect that the problem will have been the same
one.
There is nothing obvious on your last commit that should cause the problem with
the build help.
We can consider Bug 1519361 to be fixed in this branch, because it appeared on
all systems.
I just noticed one more thing:
class RenderQueue {
public:
enum Program {
Any specific re
Review: Approve
Still needs testing, but code LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_overlays.
___
Mailing list: ht
Changing a reference to a pointer can be a bit of a pain, but it isn't complex
- the compiler will tell you if anything goes wrong, so you can't mess it up.
What you need to do is change foo.bar to foo->bar within the function, and add
& or * in front of foo when calling the function - I can nev
I have created a bug for the packages that we should look at:
https://bugs.launchpad.net/widelands/+bug/1531463
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526903/+merge/281410
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1526903.
__
@kaputtnik: How are the roads? Is the fuzzy roads bug in this branch now fixed?
--
https://code.launchpad.net/~widelands-dev/widelands/render_queue/+merge/250524
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/render_queue.
_
Wasn't merged due to a typo ;)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/render_queue/+merge/250524
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/render_queue.
___
Mailing list: https:/
Thanks!
@bunnbot merge
--
https://code.launchpad.net/~widelands-dev/widelands/render_queue/+merge/250524
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/render_queue.
___
Mailing list: https://launchpad.net/~wideland
The proposal to merge lp:~widelands-dev/widelands/table_align into lp:widelands
has been updated.
Commit Message changed to:
Fixed positioning problems with long table entries and table image alignment
for BiDi languages.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelan
The proposal to merge lp:~widelands-dev/widelands/logic_directory_layout into
lp:widelands has been updated.
Commit Message changed to:
Created subdirectories in src/logic to make understanding and navigating the
code easier.
For more details, see:
https://code.launchpad.net/~widelands-dev/wid
Code still LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_overlays/+merge/281641
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_overlays.
___
Mailing list: https://launchpad.net/~widelands-dev
P
Thanks! There seems to be a new text conflict, so I'll resolve that before a
merge.
--
https://code.launchpad.net/~widelands-dev/widelands/logic_directory_layout/+merge/280354
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/logic_directory_
Added a comment to nit 2.
As for testing, create a long Latin savefile name, then grab the long Arabic
savefile name from the bug. all file- and mapnames should be properly aligned
in the Load Game and New Game screens both when you pick a Latin or an Arabic
language.
I know that navigating th
I like the idea of adding a special loading screen when Widelands is first run
- e.g. the text could read "Optimizing Widelands images for first usage" or
some such, so the user will know that they won't have to wait for this in the
future.
We should then build the texture atlas only for the cu
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/logic_directory_layout/+merge/280354
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/logic_directory_layout.
___
Mailing list: https://launchpad.n
I had another idea regarding the loading screen: ui_fsmenu doesn't really need
a performance enhancement, so we could not use the texture atlas in the
fullscreen menus and generate it in the background, then finish loading it in
the game/editor loading screens if necessary. I don't know the cons
I will try to look at the code shoonish.
Regarding a feature freeze, there are 2 things that still need doing on my end:
1. Font renderer switchover: We have 1 wordwrap bug that needs fixing
(https://bugs.launchpad.net/widelands/+bug/1530723), and after it has been
fixed, I need to merge
https
I have a VMWare VM, so I could eventually test it. I want to review the
prerequisite branch first though (the VM makes my whole machine slow when
linking...)
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
Your team Widelands Developers is subscribed to branc
Review: Approve
Some small nits, otherwise LGTM
Diff comments:
>
> === modified file 'src/graphic/make_texture_atlas_main.cc'
> --- src/graphic/make_texture_atlas_main.cc2016-01-04 20:54:08 +
> +++ src/graphic/make_texture_atlas_main.cc2016-01-07 22:08:20 +
> @@ -62,11 +88,121 @
Is this branch ready for review, or are you still playing with it?
--
https://code.launchpad.net/~widelands-dev/widelands/ai_ship_tweaks/+merge/280192
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ai_ship_tweaks.
__
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/table_align/+merge/279685
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/table_align.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/error_shadow/+merge/282225
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/error_shadow.
___
Mailing list: https://launchpad.net/~widelands-
LGTM:)
If somebody touches this code again in the future, correct English is
"dug_percentage" ;)
It can of course stay the way it is for now!
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525395/+merge/282377
Your team Widelands Developers is subscribed to branch
lp:~widelands-de
Review: Approve
New code still LGTM :)
--
https://code.launchpad.net/~widelands-dev/widelands/error_shadow/+merge/282225
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/error_shadow.
___
Mailing list: https://launchp
Some proofreading - sorry I didn't see this before.
There are no financial goal or interest. => There is no financial goal or
interest.
It is customary to use Title Case in English: Project lead => Project Lead
There are several possibilities to get in contact. For questions about the game
or
I think it would be good to have a team of 3 - so if any of us breaks it, there
would be 2 people around to help. I need to get around to making my test
installation work.
--
https://code.launchpad.net/~widelands-dev/widelands-website/copyrightyear_and_links/+merge/281450
Your team Widelands Dev
Code LGTM - just one small nit.
Not tested.
Diff comments:
>
> === modified file 'templates/wiki/edit.html'
> --- templates/wiki/edit.html 2015-04-01 20:01:41 +
> +++ templates/wiki/edit.html 2016-01-14 19:36:43 +
> @@ -117,14 +117,24 @@
>
>
Review: Approve
Code LGTM, just 1 code style nit.
I noticed that you use variable type "auto" a lot - please double-check if you
can be more specific. Strong typing is good ;)
Diff comments:
>
> === modified file 'src/editor/editorinteractive.h'
> --- src/editor/editorinteractive.h2016-0
I'm online today, so I can do some testing.
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cache/+merge/282106
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/full_texture_atlas.
___
Mailing list: ht
Fine by me, thanks for explaining.
--
https://code.launchpad.net/~widelands-dev/widelands/fix_resource_overlay/+merge/282680
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_resource_overlay.
___
Mailing list: http
I gave this a quick spin in my VM and it runs fine. There is a problem with
drawing rectangles though - got probably introduced in one of the previous
graphics branches.
https://launchpadlibrarian.net/234364565/rectangles.png
--
https://code.launchpad.net/~widelands-dev/widelands/use_image_cach
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/stricter_travis/+merge/282852
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/stricter_travis.
___
Mailing list: https://launchpad.net/~wide
Looks like my bug is https://bugs.launchpad.net/widelands/+bug/1531114 indeed -
seems more pronounced with small screen resolutions maybe?
I won't have time to look at the code until end of next week, but if everything
has been checked, it can go in.
--
https://code.launchpad.net/~widelands-dev
Maybe we can add a bash script to utils/ for the future?
--
https://code.launchpad.net/~widelands-dev/widelands/png_fix_only_relevant/+merge/283005
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/png_fix_only_relevant.
__
Added a comment regarding the todo file.
Diff comments:
>
> === added file 'debian/copyright.todo'
> --- debian/copyright.todo 1970-01-01 00:00:00 +
> +++ debian/copyright.todo 2016-01-22 18:35:40 +
> @@ -0,0 +1,34 @@
> +Documents known missing entries in the copyright file
> +
>
Review: Approve
Not tested, but code LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/cricket_frog_sounds/+merge/283511
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/cricket_frog_sounds.
___
Mailing lis
Have you tested that this doesn't regress
https://bugs.launchpad.net/widelands/+bug/1522564?
This bug was the reason I stopped using blitrect_scale.
--
https://code.launchpad.net/~widelands-dev/widelands/memory_leak/+merge/283690
Your team Widelands Developers is requested to review the proposed
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Commit message:
- Fixed numbering inconsistency in production program strings.
- Fixed Purpose helptext for Battle Ax.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1530723 into
lp:widelands.
Commit message:
WordWrap no longer checks the safety margin for empty text. This fixes a crash
in the Game Results screen.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_editor_transparency_issue/+merge/282874
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_editor_transparency_issue.
_
The problem is that blitrect_scale doesn't crop.
--
https://code.launchpad.net/~widelands-dev/widelands/memory_leak/+merge/283690
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/memory_leak into lp:widelands.
___
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1532279 into
lp:widelands.
Commit message:
Increased label height in spinboxes to avoid autogeneration of scrollbar button
by the MultilineTextarea.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug
The proposal to merge lp:~widelands-dev/widelands/bug-1532279 into lp:widelands
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1532279/+merge/283720
--
Your team Widelands Developers is requested to r
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1532279 into
lp:widelands.
Commit message:
Increased label height in spinboxes to avoid autogeneration of scrollbar button
by the MultilineTextarea.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug
GunChleoc has proposed merging
lp:~widelands-dev/widelands/codecheck_compiler_fixes into lp:widelands.
Commit message:
- Fixed some codecheck and compiler warnings
- Fixed crash with assert in launch_mpg when selection of game or map to load
is cancelled.
Requested reviews:
Widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1532279 into lp:widelands
has been updated.
Commit Message changed to:
- Increased label height in spinboxes to avoid autogeneration of scrollbar
button by the MultilineTextarea.
- Added size offset to some fonts that were too small.
For mo
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1537157 into
lp:widelands.
Commit message:
Changed msgxctxt variable for Productionsites from char* to std::string to fix
problem with loading descname translations.
Requested reviews:
Widelands Developers (widelands-dev)
Related
Review: Approve
Graphics now look OK on Ubuntu. Code LGTM.
Travis fail is because of Codecheck - I fixed all but 1 Codecheck warning in
https://code.launchpad.net/~widelands-dev/widelands/codecheck_compiler_fixes/+merge/283722.
--
https://code.launchpad.net/~widelands-dev/widelands/memory_leak/
I'll merge this without bunnybot, because the problem is with codecheck in
trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1537157/+merge/283724
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1537157.
OK, SirVer just fixed, so I'll merge trunk instead.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1537157/+merge/283724
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1537157.
___
Mailing list: https
The proposal to merge lp:~widelands-dev/widelands/codecheck_compiler_fixes into
lp:widelands has been updated.
Commit Message changed to:
- Fixed some compiler warnings
- Fixed crash with assert in launch_mpg when selection of game or map to load
is cancelled.
For more details, see:
https://co
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1537157/+merge/283724
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1537157.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1532279/+merge/283720
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1532279.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
GunChleoc has proposed merging lp:~widelands-dev/widelands/multiline_textarea
into lp:widelands.
Commit message:
MultilineTextarea now uses the new font renderer directly instead of WordWrap.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1532279 in widelands
Review: Approve
Keen eyes :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_hotspot_barbarian_brewer/+merge/283739
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fix_hotspot_barbarian_brewer.
__
Not compiled or tested yet, but code LGTM - just 2 nits.
I think the option and build requirement should be documented somewhere in the
code, because we won't find it in this commit message down the road. I think
copying the commit message to src/graphic/gl/initialize.cc should be enough for
no
"défaut" is a screwup by a French translator and I have already fixed it on
Transifex.
I know that the scrollbar shows up when the font size is bigger sometimes, this
is expected behaviour and not related to this branch. All the screens that show
this need to be switched over to Box layout. Thi
Compiler warning:
[ 11%] Building CXX object
src/graphic/CMakeFiles/graphic_gl_utils.dir/gl/initialize.cc.o
/home/bratzbert/sources/widelands/opengl_debug/src/graphic/gl/initialize.cc:32:1:
warning: unused parameter ‘trace’ [-Wunused-parameter]
initialize(const Trace& trace, SDL_Window* sdl_win
Here's my output - it complains about "debug_gl_trace" not being Boolean, both
before and after the commit regarding trace. I simply called ./compile.sh for
the compilation, is the switch in CMake set?
[] [/home/bratzbert/sources/widelands/opengl_debug/src/profile/profile.cc:167]
debug_gl_trac
My fault, I passed --debug_gl_trace instead of --debug_gl_trace=yes
My system can't handle ninja, so I tried now:
mkdir build
cd build
cmake -DOPTION_USE_GLBINDING:BOOL=ON -DCMAKE_BUILD_TYPE:STRING="Debug" ..
Which gives me:
CMake Error at CMakeLists.txt:60 (find_package):
By not providing "F
Duh, I need to install glbinding first... compiling now.
--
https://code.launchpad.net/~widelands-dev/widelands/opengl_debug/+merge/283738
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/opengl_debug into lp:widelands.
_
OK, next problem:
bratzbert@museum:~/sources/widelands/opengl_debug$ cd build
bratzbert@museum:~/sources/widelands/opengl_debug/build$ cmake
-DOPTION_USE_GLBINDING:BOOL=ON -DCMAKE_BUILD_TYPE:STRING="Debug" .
-- Boost version: 1.54.0
-- Found the following Boost libraries:
-- unit_test_framework
There was one remaining instance of that bug for Gaelic language only in the
options window, which has now disappeared.
The reason for this is to speed up rendering - you should notice that map
descriptions now load faster again.
@wl-zocker: it is "translatable" in the sense that you use it to
Review: Approve
I can compile and run Widelands now.
--
https://code.launchpad.net/~widelands-dev/widelands/opengl_debug/+merge/283738
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/opengl_debug.
___
Mailing list: h
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/copyright-file/+merge/283575
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/copyright-file into lp:widelands.
___
Mail
Before I consitune working on this, we need to fix the issues with the
regression suite. I have been unable to crack this, and it's the reason this
branc is still sitting here. Would you like to take this on for me?
Here's what I wrote about the problem:
I have changed the global datadir to "./
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1525680 into
lp:widelands.
Commit message:
Richtext and rt_render can now handle . Shifted handling of < and >
from parser to renderer.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1525
GunChleoc has proposed merging lp:~widelands-dev/widelands/editor_help into
lp:widelands.
Commit message:
Exposed terrain and resource descriptions to the Lua interface and added tree
and terrain help to the editor.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug
The proposal to merge lp:~widelands-dev/widelands/bug-1526916 into lp:widelands
has been updated.
Commit Message changed to:
When selecting a map, the parent directory now has a lower sort order than all
other directories.
For more details, see:
https://code.launchpad.net/~widelands-dev/widela
When selecting a map, the parent directory now has a lower sort order than all
other directories.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526916/+merge/283912
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1526916 i
The proposal to merge lp:~widelands-dev/widelands/bug-1526916 into lp:widelands
has been updated.
Description changed to:
When selecting a map, the parent directory now has a lower sort order than all
other directories.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1526916 into
lp:widelands.
Commit message:
When selecting a map, the parent directory now has a lower sort order than all
other directories.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1526916 in
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/multiline_textarea/+merge/283736
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/multiline_textarea into lp:widelands.
___
Ma
I see your point - done :)
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/editor_help into lp:widelands.
___
Maili
Thanks for collecting all the info :)
Just 3 nits regarding formatting.
Diff comments:
> === modified file 'ChangeLog'
> --- ChangeLog 2013-10-20 15:54:31 +
> +++ ChangeLog 2016-01-26 11:39:20 +
> @@ -1,3 +1,280 @@
> +### Build 19 until now
### Build 19 until r7734
This way, we still k
Review: Approve
Code LGTM, not tested yet.
--
https://code.launchpad.net/~widelands-dev/widelands/avoid_wraparound/+merge/284067
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/avoid_wraparound.
___
Mailing list: htt
We could combine the prosa from the development reports, what do you think?
--
https://code.launchpad.net/~widelands-dev/widelands/changelog_license_date/+merge/283871
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/changelog_license_date in
Thanks - will have a look.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1397500.
___
Mailing list: https://launchpad.net/~widelan
Thanks - bookmarked for fixing :)
--
https://code.launchpad.net/~widelands-dev/widelands/multiline_textarea/+merge/283736
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/multiline_textarea.
___
Mailing list: https://l
Isn't it fun that 0 still evaluates to NULL...
Code LGTM and tested. Travis also looks clean.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fix_huge_boxes/+merge/284176
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelan
Review: Resubmit
This is ready for testing and review now.
I tried clicking on everything that has an image in it, but I might have missed
something.
The packaging also needs to be tested for all OSses.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860
Your team
The proposal to merge lp:~widelands-dev/widelands/bug-1397500 into lp:widelands
has been updated.
Commit Message changed to:
Moved all data-related directories into a new "data" directory.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/243860
--
Y
Agreed - the development reports are definitely too long for this, but they
might be easier as a point of departure than a list of fixed bugs.
I'd say we wait until we're about to branch the release candidate before we
touch this again?
@bunnybot merge
--
https://code.launchpad.net/~widelands-
Review: Approve
I can't reproduce the problem, so somebody else will need to test.
Code LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/padding_in_atlas/+merge/284216
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/padding_in_atlas.
_
Review: Approve
LGTM
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/load_library/+merge/284218
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/load_library.
___
Mailing list: https://launchpa
I had a look at
http://bazaar.launchpad.net/~widelands-dev/widelands/bug-1397500/view/head:/utils/win32/mingw/config.h
and I don't know if the . in the datadir needs removing or something. SInce I
can't test on Windows, it's hard for me to play with stuff.
The variable that needs setting is dat
801 - 900 of 4401 matches
Mail list logo
