https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #1 from Tisza Gergő ---
This is expected behavior when there are network or backend errors. The
interface is ugly, we didn't have time to make a proper error page yet (that
would be
https://wikimedia.mingle.thoughtworks.com/projects
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
T. Gries changed:
What|Removed |Added
Priority|Unprioritized |High
URL|
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #3 from T. Gries ---
This bug is very annoying, pls. can you fix this with a high priority ?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #4 from Mark Holmquist ---
This happens when thumbnails aren't ready...I think the reason it doesn't break
in production is that thumb.php is our 404 handler for thumbnails.
--
You are receiving this mail because:
You are the assi
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
T. Gries changed:
What|Removed |Added
Version|unspecified |master
--
You are receiving this mail beca
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #6 from T. Gries ---
(In reply to Mark Holmquist from comment #4)
> This happens when thumbnails aren't ready...I think the reason it doesn't
> break in production is that thumb.php is our 404 handler for thumbnails.
Ah, a good poi
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #5 from Mark Holmquist ---
https://www.mediawiki.org/wiki/Manual:Thumb.php#404_Handler
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #7 from T. Gries ---
"mid-air collision". thx
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wi
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #8 from T. Gries ---
Should be documented in E:MultimediaViewer Installation (wiki and repo)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #9 from T. Gries ---
@Mark: I will try to test this as soon as possible and report my results
(later) here.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #10 from Tisza Gergő ---
The image should be generated by the imageinfo API request AFAIK. Might try to
set $wgMediaViewerUseThumbnailGuessing = false although in theory that should
still work without a 404 handler, just less effici
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #27 from Andre Klapper ---
https://gerrit.wikimedia.org/r/#/c/142475/ still left here.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #28 from Gerrit Notification Bot ---
Change 142475 merged by jenkins-bot:
Disable thumbnail URL guessing by default
https://gerrit.wikimedia.org/r/142475
--
You are receiving this mail because:
You are the assignee for the bug.
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #29 from Gerrit Notification Bot ---
Change 154876 had a related patch set uploaded by Gergő Tisza:
Disable thumbnail URL guessing by default
https://gerrit.wikimedia.org/r/154876
--
You are receiving this mail because:
You are t
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #30 from Gerrit Notification Bot ---
Change 154876 merged by Gergő Tisza:
Disable thumbnail URL guessing by default
https://gerrit.wikimedia.org/r/154876
--
You are receiving this mail because:
You are the assignee for the bug.
Y
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
Tisza Gergő changed:
What|Removed |Added
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|---
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
Andre Klapper changed:
What|Removed |Added
Flags||Backport_to_Stable+
--
You are receiv
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #11 from T. Gries ---
(In reply to Tisza Gergő from comment #10)
> The image should be generated by the imageinfo API request AFAIK. Might try
> to set $wgMediaViewerUseThumbnailGuessing = false although in theory that
> should stil
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #12 from T. Gries ---
@Tisza, @Mark:
was my test and reply quick enough? ;-)
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #13 from Tisza Gergő ---
Do you have a public wiki where I could test this? I would still like to see
how thumbnail guessing fails; it tries to load the image without making an API
request (which will fail with certain wiki configur
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #14 from T. Gries ---
(In reply to Tisza Gergő from comment #13)
> Do you have a public wiki where I could test this?
Currently: I don't have any public wiki ready with the extension, but I can set
up a my testwikis which run as w
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #15 from Tisza Gergő ---
(In reply to T. Gries from comment #14)
> I can say, the whole day, I had not a single failure on my big enterprise
> wikis any more, which is great news. In my view, you should simply set the
> default valu
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
Laurence 'GreenReaper' Parry changed:
What|Removed |Added
CC||greenrea...@hotmail.com
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #17 from Laurence 'GreenReaper' Parry ---
Also, Firefox is showing your two requests for the same image coming
immediately in succession, with the call to imageinfo coming *after* both
requests. In this situation, it will never work
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #18 from Tisza Gergő ---
(In reply to Laurence 'GreenReaper' Parry from comment #16)
> I can confirm, the default $wgMediaViewerUseThumbnailGuessing = true doesn't
> always work right if you don't have a 404 handler set up. Here's w
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
Morbus Iff changed:
What|Removed |Added
CC||mor...@disobey.com
--- Comment #19 from M
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #20 from Laurence 'GreenReaper' Parry ---
> Adding no-cache would defeat the point of thumbnail guessing, which is
> to shave off a few hundred milliseconds from the image loading time.
I think you missed the point - your second re
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
Gerrit Notification Bot changed:
What|Removed |Added
Status|NEW |PATCH_TO_REVIEW
--
You are
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #21 from Gerrit Notification Bot ---
Change 142475 had a related patch set uploaded by Gergő Tisza:
Disable thumbnail URL guessing by default
https://gerrit.wikimedia.org/r/142475
--
You are receiving this mail because:
You are t
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #22 from Gerrit Notification Bot ---
Change 142476 had a related patch set uploaded by Gergő Tisza:
Keep thumbnail guessing enabled
https://gerrit.wikimedia.org/r/142476
--
You are receiving this mail because:
You are the assigne
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #23 from Tisza Gergő ---
(In reply to Laurence 'GreenReaper' Parry from comment #20)
> I think you missed the point - your second request *may get a 404* if you
> simply repeat it, even if the image _has_ been generated on the serve
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #24 from Laurence 'GreenReaper' Parry ---
I think we've been misunderstanding each other, but it's my fault. :-)
What I was trying to say was that even when I set this variable to "false",
there was an issue loading the image; it'd
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #25 from Tisza Gergő ---
Thanks for clearing that up!
Yeah, site-wide settings are passed via ResourceLoader which generates static
.js files from them. I don't know the details of the caching strategy, but on
WMF sites it's typica
https://bugzilla.wikimedia.org/show_bug.cgi?id=64554
--- Comment #26 from Gerrit Notification Bot ---
Change 142476 merged by jenkins-bot:
Keep thumbnail guessing enabled
https://gerrit.wikimedia.org/r/142476
--
You are receiving this mail because:
You are the assignee for the bug.
You are on
34 matches
Mail list logo