https://bugzilla.wikimedia.org/show_bug.cgi?id=21161

           Summary: Uploading LocalSettings.php does not always invalidate
                    the file cache
           Product: MediaWiki
           Version: 1.15.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: Normal
         Component: Images and files
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: manfre...@arcor.de


I switched off Ajax in LocalSetting.php by using $wgUseAjax = false. Still some
pages included the script ajax.js.

The reason for this was the file cache which has not been invalidated by
updating LocalSettings.php.

The cause for the problem is the following:
index.php is trying the file cache in line 85:
  if( $cache->isFileCacheGood( /* Assume up to date */ ) ) {

isFileCacheGood in HTMLFileCache.php reacts this way:
  if( !$timestamp ) return true; // should be invalidated on change

Therefore the cached page is used and $wgCacheEpoch is ignored.

The correct code for isFileCacheGood is:
if( !$this->isFileCached() ) return false;
  $cachetime = $this->fileCacheTime();
  if( !$timestamp && ( $wgCacheEpoch <= $cachetime) ) return true; // should be
invalidated on change

$good = ...


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to