https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #20 from Reedy 2011-01-01 01:22:55 UTC ---
So, 2 explicitally reported bugs now fixed.
Improved query for Tags in r79365 based on the above help...
Wonder what else needs fixing up...
--
Configure bugmail: https://bugzilla.wikim
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Bug 24479 depends on bug 25437, which changed state.
Bug 25437 Summary: Increase release notes range
https://bugzilla.wikimedia.org/show_bug.cgi?id=25437
What|Old Value |New Value
--
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Blocks|25437 |
Depends on|
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Blocks|23720 |
Depends on|
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Blocks|26529 |
--
Configure bugmail: https://bugzilla.wikim
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Blocks||26529
--
Configure bugmail: https://bugzilla.
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #19 from Roan Kattouw 2010-12-31 20:17:29
UTC ---
(In reply to comment #18)
> Yes, the COUNT() should be killed. Its results aren't displayed in trunk
> anymore anyway.
Ignore me, this is a different COUNT
--
Configure bugmail: h
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #18 from Roan Kattouw 2010-12-31 20:12:02
UTC ---
(In reply to comment #11)
> (Of course, the query isn't scalable anyway due to COUNT(). It will have to
> scan arbitrarily many rows. The only way to fully fix it would be to use
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #17 from Reedy 2010-12-31 20:07:08 UTC ---
mysql> describe SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
comments,cr_path,cr_message,cr_author,cr_timestamp FROM `mw_code_tags` FORCE
INDEX (ct_repo_id),`mw_code_rev` LEFT
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #16 from Aryeh Gregor 2010-12-31
20:04:49 UTC ---
Then it's probably lack of equality propagation. Change cr_id to ct_rev_id in
the ORDER BY and GROUP BY clauses.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cg
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #15 from Reedy 2010-12-31 20:01:59 UTC ---
mysql> describe SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
comments,cr_path,cr_message,cr_author,cr_timestamp FROM
`mw_code_tags`,`mw_code_rev` LEFT JOIN `mw_code_comment` O
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #14 from Aryeh Gregor 2010-12-31
19:49:18 UTC ---
Oops, yeah, I missed the index. Try adding FORCE INDEX (ct_repo_id) and see
what that gives you.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #13 from Reedy 2010-12-31 19:45:12 UTC ---
-- Freetext tagging for revisions
CREATE TABLE /*_*/code_tags (
ct_repo_id int not null,
ct_rev_id int not null,
ct_tag varbinary(255) not null,
primary key (ct_repo_id,ct_rev_id,c
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #12 from Reedy 2010-12-31 19:21:15 UTC ---
(In reply to comment #10)
> This is a classic pitfall for the MySQL optimizer. What version are you
> using?
> On the toolserver, 5.1.53, it avoids the filesort.
re...@ubuntu64-esxi:~$
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #11 from Aryeh Gregor 2010-12-31
18:22:29 UTC ---
(Of course, the query isn't scalable anyway due to COUNT(). It will have to
scan arbitrarily many rows. The only way to fully fix it would be to use a
summary table of some kind,
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #10 from Aryeh Gregor 2010-12-31
18:21:21 UTC ---
(In reply to comment #7)
> mysql> describe SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
> comments,cr_path,cr_message,cr_author,cr_timestamp FROM
> `mw_code_tags`,`mw_
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #9 from Reedy 2010-12-31 06:44:21 UTC ---
I suppose, also, sorting/group by cr_id isn't much good when it's unindexed
directly/as the first column
PK is cr_repo_id, cr_id
Though, adding the index doesn't help.
The discussio
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #8 from Reedy 2010-12-31 06:00:11 UTC ---
mysql> describe SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
comments,cr_path,cr_message,cr_author,cr_timestamp FROM
`mw_code_tags`,`mw_code_rev` LEFT JOIN `mw_code_comment` ON
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #7 from Reedy 2010-12-31 05:53:59 UTC ---
It's the order by/group by not being on the first table...
mysql> describe SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
comments,cr_path,cr_message,cr_author,cr_timestamp FRO
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Blocks||26394
--
Configure bugmail: https://bugzilla.
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #6 from Reedy 2010-12-04 22:05:00 UTC ---
Reedy: the generic problem is: there is code_something with cs_repo_id,
cs_rev_id and cs_value; the only index is primary key on all three columns in
the order listed. There is code_rev whi
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #5 from Reedy 2010-12-04 19:27:03 UTC ---
Special:Code/MediaWiki/tag/api
ie
SELECT cr_id,cr_repo_id,cr_status,COUNT(DISTINCT cc_id) AS
comments,cr_path,cr_message,cr_author,cr_timestamp FROM `code_tags`,`code_rev`
LEFT JOIN `code_
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Roan Kattouw changed:
What|Removed |Added
CC||roan.katt...@gmail.com
--- Comment #4 f
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
--- Comment #3 from Reedy 2010-10-23 13:47:33 UTC ---
I've got the mysql high performance book if anyone wants it for that bug
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail be
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Chad H. changed:
What|Removed |Added
Keywords||bugsmash
AssignedTo|wikibug...@lists
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Chad H. changed:
What|Removed |Added
Blocks||25437
--
Configure bugmail: https://bugzill
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Max Semenik changed:
What|Removed |Added
Blocks||23720
--
Configure bugmail: https://bug
https://bugzilla.wikimedia.org/show_bug.cgi?id=24479
Reedy changed:
What|Removed |Added
Summary|CodeReview sucks|CodeReview has many
|
28 matches
Mail list logo
