https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Sumana Harihareswara changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Dereckson changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Tyler Romeo changed:
What|Removed |Added
Keywords|patch, patch-reviewed |patch-in-gerrit
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Sumana Harihareswara changed:
What|Removed |Added
Keywords||patch-reviewed
--- Comment #11
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Krinkle changed:
What|Removed |Added
Version|1.16.0 |1.16.x
--
Configure bugmail: https://bugzil
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Sumana Harihareswara changed:
What|Removed |Added
CC||suma...@panix.com
--- Comment #
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Mark A. Hershberger changed:
What|Removed |Added
Keywords||patch
CC|
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #9 from Brion Vibber 2011-01-08 01:50:33 UTC ---
It *shouldn't* be possible for REMOTE_ADDR to contain more than one IP, but it
looks like it can happen if the server's using something like this apache
module: http://stderr.net/apac
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Ilmari Karonen changed:
What|Removed |Added
Attachment #7954|0 |1
is obsolete|
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Platonides changed:
What|Removed |Added
CC||platoni...@gmail.com
--- Comment #7 from
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #6 from Ilmari Karonen 2011-01-05 19:12:03 UTC
---
I was assuming the loop below was doing that already, but now I see that I'd
been reading it wrong. New patch coming soon.
--
Configure bugmail: https://bugzilla.wikimedia.org/u
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #5 from Charles Broughton 2011-01-05
19:09:01 UTC ---
Should you not canonicalize the parts then reformat it?
@Iimari Karonen
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #4 from Ilmari Karonen 2011-01-05 19:06:26 UTC
---
Created attachment 7954
--> https://bugzilla.wikimedia.org/attachment.cgi?id=7954
A quick draft of a patch to fix this (not tested)
Here's a quick patch that should at least sto
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #3 from Charles Broughton 2011-01-05
18:50:42 UTC ---
TESTCASE: http://dpaste.com/hold/294530/
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
--- Comment #2 from Charles Broughton 2011-01-05
18:47:53 UTC ---
You should use the LAST technically, as under apache the FIRST is the
X_FORWARDED_BY. Or perhaps you should test against X_FORWARDED_FOR ? Because
that ALSO returns two IPs...
https://bugzilla.wikimedia.org/show_bug.cgi?id=26585
Ilmari Karonen changed:
What|Removed |Added
CC||nos...@vyznev.net
--- Comment #1 from
16 matches
Mail list logo
