[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Bryan Tong Minh changed: What|Removed |Added CC||krinklem...@gmail.com --- Comment #1

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 duplicate...@googlemail.com changed: What|Removed |Added CC||er...@darcoury.nl --- Com

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Bryan Tong Minh changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #12 from Mark A. Hershberger 2011-04-27 22:59:25 UTC --- (In reply to comment #11) > I could just commit the SpecialListfiles.php patch and open a new bug for the > thumbnail sizing bug... I think that would be good. -- Configur

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Mark A. Hershberger changed: What|Removed |Added Keywords|triage | -- Configure bugmail: https://

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #11 from Bryan Tong Minh 2011-04-26 08:07:11 UTC --- (In reply to comment #10) > This patch seems to have two parts: > * fix Special:Listfiles specifically to use a maximum box height (easy > one-line > fix) Correct, that is indee

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #10 from Brion Vibber 2011-04-25 23:38:19 UTC --- This patch seems to have two parts: * fix Special:Listfiles specifically to use a maximum box height (easy one-line fix) * a general change to thumbnailing box sizing Is that gener

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #9 from Bryan Tong Minh 2011-04-23 19:09:32 UTC --- (In reply to comment #8) > (In reply to comment #7) > > At the end of the day, such narrow images are an edgecase. I don't think > > it'd > > be that bad if they just weren't ren

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #8 from Mark A. Hershberger 2011-04-23 19:06:36 UTC --- (In reply to comment #7) > At the end of the day, such narrow images are an edgecase. I don't think it'd > be that bad if they just weren't rendered in the thumbnail spot. I'

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #7 from Bawolff 2011-04-23 16:01:43 UTC --- At the end of the day, such narrow images are an edgecase. I don't think it'd be that bad if they just weren't rendered in the thumbnail spot. -- Configure bugmail: https://bugzilla.wiki

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #6 from Bryan Tong Minh 2011-04-23 09:09:20 UTC --- I'd like to have somebody look over the patch before I apply it. I'm not convinced of the sanity of my changes to Generic.php. -- Configure bugmail: https://bugzilla.wikimedia.o

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #5 from Mark A. Hershberger 2011-04-23 03:25:32 UTC --- are you planning to do anything else with this patch? Apply it, say? We'll at least look at it in triage. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cg

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Bryan Tong Minh changed: What|Removed |Added Keywords||need-review, patch -- Configure bug

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #4 from Bryan Tong Minh 2011-04-22 19:16:49 UTC --- Created attachment 8449 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8449 Patch which modifies the way target width and height are calculated Fixed in attached patch, b

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #3 from Bryan Tong Minh 2011-04-22 18:58:17 UTC --- Hmm this is more difficult than I thought... How do you properly scale a 1x449 image to 360 pixels height? The proper height would be 0.80 pixels and for various reasons MediaWiki

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Bryan Tong Minh changed: What|Removed |Added AssignedTo|wikibugs-l@lists.wikimedia. |bryan.tongm...@gmail.com

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Mark A. Hershberger changed: What|Removed |Added Keywords||triage CC|

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 Jon Harald Søby changed: What|Removed |Added CC||jhs...@gmail.com --- Comment #2 from

[Bug 28076] Thumbnail feature in Special:listfiles doesn't handle very narrow images well.

https://bugzilla.wikimedia.org/show_bug.cgi?id=28076 --- Comment #1 from Bryan Tong Minh 2011-03-16 22:10:12 UTC --- 2:1 would be most appropriate I think, so 360px. I believe that passing 360 as height to File::transform is sufficient for MediaHandler to box-fit the image, but I'd need to check