[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Brion Vibber changed: What|Removed |Added Depends on|29784 | --- Comment #28 from Brion Vibber 201

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Mark A. Hershberger changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Mark A. Hershberger changed: What|Removed |Added Blocks|29068 |29097 -- Configure bugmail: htt

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Brion Vibber changed: What|Removed |Added Depends on||29784 --- Comment #26 from Brion Vibber

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #25 from Brion Vibber 2011-07-06 21:51:40 UTC --- Ok r91591 adds JSMin+ to libs and uses its parser on the minifier unit tests (now tweaked to be valid JS programs). r91608 adds a $wgResourceLoaderValidateJs option (on by default)

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #24 from P.Copp 2011-07-06 21:42:09 UTC --- Sorry, I meant bug 26791 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #23 from P.Copp 2011-07-06 21:40:52 UTC --- (In reply to comment #21) > It's probably worth comparing jsmin+'s minification qualities to our current > home-grown minifier; it sounds like just swapping to jsmin+ as a minifier > mig

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #22 from Brion Vibber 2011-07-06 19:04:07 UTC --- Created attachment 8752 --> https://bugzilla.wikimedia.org/attachment.cgi?id=8752 Quick patch adding jsmin+ and running its JS parser on JavaScriptMinifier test case results This

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #21 from Brion Vibber 2011-07-06 17:45:30 UTC --- I've done a little prelim poking at a custom parser for my own edification (mostly to make sure I better understood the ECMAScript specs) but it's a relatively low priority for me.

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #20 from Mark A. Hershberger 2011-07-06 16:54:18 UTC --- Did you guys decide to use jsmin* or did brion write his own? How close are we to closing this? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=emai

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #19 from P.Copp 2011-06-29 07:28:12 UTC --- (In reply to comment #18) > Since I'm brushing up on my low-level parsing skills anyway ;) I'm making a > quick stab at building a PHP-based recursive-descent parser following the > lexic

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Brion Vibber changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #18 from Brion Vib

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 --- Comment #17 from Krinkle 2011-06-28 23:32:59 UTC --- Just for the record, having a JSLint or JSHint (that is GPL) compatible in PHP doesn't (directly) help this bug getting fixed. Many lints and hints are good practices or could cause con

[Bug 28626] JS syntax errors should not affect other modules in a load.php request

https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 Krinkle changed: What|Removed |Added Summary|JS syntax errors affect |JS syntax errors should not